[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #3658: Support SSL for Kyuubi thrift binary connection

[GitBox <gi...@apache.org>]

yaooqinn commented on code in PR #3658:
URL: https://github.com/apache/incubator-kyuubi/pull/3658#discussion_r1001276847


##########
docs/deployment/settings.md:
##########
@@ -296,9 +296,16 @@ kyuubi.frontend.protocols|THRIFT_BINARY|A comma separated list for all frontend
 kyuubi.frontend.proxy.http.client.ip.header|X-Real-IP|The http header to record the real client ip address. If your server is behind a load balancer or other proxy, the server will see this load balancer or proxy IP address as the client IP address, to get around this common issue, most load balancers or proxies offer the ability to record the real remote IP address in an HTTP header that will be added to the request for other devices to use. Note that, because the header value can be specified to any ip address, so it will not be used for authentication.|string|1.6.0
 kyuubi.frontend.rest.bind.host|<undefined>|Hostname or IP of the machine on which to run the REST frontend service.|string|1.4.0
 kyuubi.frontend.rest.bind.port|10099|Port of the machine on which to run the REST frontend service.|int|1.4.0
+kyuubi.frontend.ssl.exclude.protocols|SSLv2,SSLv3|SSL Versions to disable.|seq|1.7.0

Review Comment:
   irrelevant with kyuubi.frontend.thrift.http.ssl.protocol.blacklist？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org