You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by emidln <gi...@git.apache.org> on 2015/05/28 00:09:34 UTC
[GitHub] storm pull request: Remove unused clj-time dependency from storm-c...
GitHub user emidln opened a pull request:
https://github.com/apache/storm/pull/564
Remove unused clj-time dependency from storm-core
clj-time was formerly used by UI, but is no longer. This removes
clj-time (and thus joda-time 2.0). This might be a breaking change
if a user assumes joda-time 2.0 or clj-time 0.8.0 is provided by
the worker on the classpath.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/emidln/storm emidln/remove-clj-time
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/564.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #564
----
commit f3e725bc03f7bfed626d04d3c4d1d1ac63c27ab3
Author: Brandon Adams <em...@gmail.com>
Date: 2015-05-27T22:04:39Z
Remove unused clj-time dependency from storm-core
clj-time was formerly used by UI, but is no longer. This removes
clj-time (and thus joda-time 2.0). This might be a breaking change
if a user assumes joda-time 2.0 or clj-time 0.8.0 is provided by
the worker on the classpath.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Remove unused clj-time dependency from storm-c...
Posted by emidln <gi...@git.apache.org>.
Github user emidln commented on the pull request:
https://github.com/apache/storm/pull/564#issuecomment-106136107
Ugh. Withdrawing this. If we don't pin clj-time 0.8.0, we get 0.3.7 from ring-core.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Remove unused clj-time dependency from storm-c...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/564#issuecomment-106146658
Oh, I didn't check about dependencies changeset. Sorry!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Remove unused clj-time dependency from storm-c...
Posted by emidln <gi...@git.apache.org>.
Github user emidln closed the pull request at:
https://github.com/apache/storm/pull/564
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Remove unused clj-time dependency from storm-c...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/564#issuecomment-106102399
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---