You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Robert Munteanu (JIRA)" <ji...@apache.org> on 2013/09/29 13:45:33 UTC
[jira] [Issue Comment Deleted] (FELIX-4249) Make the default error
location 1,1 instead of 0,0
[ https://issues.apache.org/jira/browse/FELIX-4249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Munteanu updated FELIX-4249:
-----------------------------------
Comment: was deleted
(was: There's a patch attached to this issue, but just in case Jira is flaky:
{code}Index: scrplugin/generator/src/main/java/org/apache/felix/scrplugin/helper/IssueLog.java
===================================================================
--- scrplugin/generator/src/main/java/org/apache/felix/scrplugin/helper/IssueLog.java (revision 1526957)
+++ scrplugin/generator/src/main/java/org/apache/felix/scrplugin/helper/IssueLog.java (working copy)
@@ -102,8 +102,8 @@
private static class Entry {
- static final int LINE_NUMBER_UNKNOWN = 0;
- static final int COLUMN_NUMBER_UNKNOWN = 0;
+ static final int LINE_NUMBER_UNKNOWN = 1;
+ static final int COLUMN_NUMBER_UNKNOWN = 1;
final String message;
final String location;
{code})
> Make the default error location 1,1 instead of 0,0
> --------------------------------------------------
>
> Key: FELIX-4249
> URL: https://issues.apache.org/jira/browse/FELIX-4249
> Project: Felix
> Issue Type: Improvement
> Components: Maven SCR Plugin
> Affects Versions: scr generator 1.8.0
> Reporter: Robert Munteanu
> Assignee: Carsten Ziegeler
> Priority: Minor
> Fix For: maven-scr-plugin 1.15.0, scr ant task 1.9.0, scr generator 1.8.2
>
> Attachments: FELIX-4249-1.patch
>
>
> The scr generator's error reporting places the errors by default at the 0,0 coordinates. In practice, this means that in Eclipse the error/warning is associated with the file and shown in the problems view but not in the editor.
> To make this more visible, I suggest that we change the error location to 1,1, which places it in the first line of the file. Should we want to, we can extract line ( but not column ) information from ASM to place the warning closer to the source.
--
This message was sent by Atlassian JIRA
(v6.1#6144)