You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Julian Hyde (JIRA)" <ji...@apache.org> on 2018/02/07 01:40:00 UTC

[jira] [Commented] (CALCITE-2171) ExampleFunctionTest is not reading model.json

    [ https://issues.apache.org/jira/browse/CALCITE-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16354845#comment-16354845 ] 

Julian Hyde commented on CALCITE-2171:
--------------------------------------

In my opinion, it's not a problem that it doesn't read model.json. Calcite has a schema SPI, and a JSON model just one way to create a model. {{ExampleFunctionTest}} creates a model with two functions by calling {{SchemaPlus.add(String, Function)}}, and that's fine.

> ExampleFunctionTest is not reading model.json 
> ----------------------------------------------
>
>                 Key: CALCITE-2171
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2171
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Shuyi Chen
>            Assignee: Shuyi Chen
>            Priority: Major
>
> ExampleFunctionTest is not reading model.json at all. I think we can either remove it, or modify the code to read model.json. Please let me know.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)