You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "DaanHoogland (via GitHub)" <gi...@apache.org> on 2023/03/24 12:29:19 UTC

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7365: ui: allow filtering account by state

DaanHoogland commented on code in PR #7365:
URL: https://github.com/apache/cloudstack/pull/7365#discussion_r1147517795


##########
ui/src/views/AutogenView.vue:
##########
@@ -1580,6 +1581,8 @@ export default {
         } else if (['running', 'stopped'].includes(filter)) {
           query.state = filter
         }
+      } else if (this.$route.name === 'account') {
+        query.state = filter

Review Comment:
   we can unify this with the case of 'publicip'. i.e.
   ```suggestion
         } else if (['account', 'publicip'].includes(this.$route.name)) {
           query.state = filter
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org