[GitHub] spark pull request #18561: [WIP][TEST][test-maven] createSparkSession should...

[srowen <gi...@git.apache.org>]

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18561#discussion_r126080296
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/test/SharedSQLContext.scala ---
    @@ -61,8 +61,10 @@ trait SharedSQLContext extends SQLTestUtils with BeforeAndAfterEach with Eventua
        */
       protected override def beforeAll(): Unit = {
         SparkSession.sqlListener.set(null)
    -    if (_spark == null) {
    -      _spark = createSparkSession
    +    synchronized {
    --- End diff --
    
    `beforeAll` ought to be called by one thread in the test framework before any tests start. I doubt this is the reason, but, maybe I don't have the full context here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org