[GitHub] [shardingsphere] FakeKotaro opened a new pull request, #26731: Support RLIKE parse for MySQL

["FakeKotaro (via GitHub)" <gi...@apache.org>]

FakeKotaro opened a new pull request, #26731:
URL: https://github.com/apache/shardingsphere/pull/26731

   Fixes #25535 #26687 
   
   Changes proposed in this pull request:
     - Support RLIKE parse for MySQL
     - Add test sql
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [x] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [x] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu merged pull request #26731: Support RLIKE parse for MySQL

["strongduanmu (via GitHub)" <gi...@apache.org>]

strongduanmu merged PR #26731:
URL: https://github.com/apache/shardingsphere/pull/26731


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #26731: Support RLIKE parse for MySQL

["strongduanmu (via GitHub)" <gi...@apache.org>]

strongduanmu commented on code in PR #26731:
URL: https://github.com/apache/shardingsphere/pull/26731#discussion_r1250174708


##########
parser/sql/dialect/mysql/src/main/antlr4/imports/mysql/BaseRule.g4:
##########
@@ -872,7 +872,7 @@ predicate
     | bitExpr NOT? BETWEEN bitExpr AND predicate
     | bitExpr SOUNDS LIKE bitExpr
     | bitExpr NOT? LIKE simpleExpr (ESCAPE simpleExpr)?
-    | bitExpr NOT? REGEXP bitExpr
+    | bitExpr NOT? (REGEXP | RLIKE) bitExpr

Review Comment:
   Since RLIKE and REGEXP are synonyms, this change is ok.
   
   https://github.com/mysql/mysql-server/blob/ea7087d885006918ad54458e7aad215b1650312c/sql/lex.h#L610



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org