You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ian Downes <ia...@gmail.com> on 2015/06/01 23:48:30 UTC

Review Request 34908: Rename --docker_sandbox_directory flag for general use.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34908/
-----------------------------------------------------------

Review request for mesos and Timothy Chen.


Repository: mesos


Description
-------

Rename --docker_sandbox_directory flag for general use.

This will require users to update configuration scripts etc if they specify the old flag.


Diffs
-----

  docs/configuration.md 4e20913cf7a088997235f399733c89db3441fb7c 
  src/slave/containerizer/docker.cpp 41e0b98c387e57b692df4c56ae21ce70f67f9a19 
  src/slave/flags.hpp 84dbb8a2aa963bb38cf0f610ab442b626179b173 
  src/slave/flags.cpp ab8709861eb037e75dd2e91a097048ea6cd20c9c 
  src/tests/docker_containerizer_tests.cpp 3a983c6813dab6fa03ccb2c87e1ea71866766d6e 

Diff: https://reviews.apache.org/r/34908/diff/


Testing
-------


Thanks,

Ian Downes

Re: Review Request 34908: Rename --docker_sandbox_directory flag for general use.

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34908/#review86294
-----------------------------------------------------------

Ship it!


Ship It!

- Timothy Chen


On June 1, 2015, 9:48 p.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34908/
> -----------------------------------------------------------
> 
> (Updated June 1, 2015, 9:48 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Rename --docker_sandbox_directory flag for general use.
> 
> This will require users to update configuration scripts etc if they specify the old flag.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 4e20913cf7a088997235f399733c89db3441fb7c 
>   src/slave/containerizer/docker.cpp 41e0b98c387e57b692df4c56ae21ce70f67f9a19 
>   src/slave/flags.hpp 84dbb8a2aa963bb38cf0f610ab442b626179b173 
>   src/slave/flags.cpp ab8709861eb037e75dd2e91a097048ea6cd20c9c 
>   src/tests/docker_containerizer_tests.cpp 3a983c6813dab6fa03ccb2c87e1ea71866766d6e 
> 
> Diff: https://reviews.apache.org/r/34908/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ian Downes
> 
>

Re: Review Request 34908: Rename --docker_sandbox_directory flag for general use.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34908/#review91430
-----------------------------------------------------------


Code looks good

- Guangya Liu


On July 12, 2015, 4:41 a.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34908/
> -----------------------------------------------------------
> 
> (Updated July 12, 2015, 4:41 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Rename --docker_sandbox_directory flag for general use.
> 
> This will require users to update configuration scripts etc if they specify the old flag.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md feee5594c88112f77ce382cb3dd8628653f92d01 
>   src/slave/containerizer/docker.cpp cfb60177fe48ec0eeab12ff392c6c9f89634b92f 
>   src/slave/flags.hpp 26c778db2303167369af8675fe0441a00a1e9151 
>   src/slave/flags.cpp 8632677ebbdbfef8ffa45204b6f63a700baff7f3 
>   src/tests/docker_containerizer_tests.cpp a3da786c1b733e9dd4abf1d02d5dae051393d921 
> 
> Diff: https://reviews.apache.org/r/34908/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ian Downes
> 
>

Re: Review Request 34908: Rename --docker_sandbox_directory flag for general use.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34908/#review91431
-----------------------------------------------------------

Ship it!


- Guangya Liu


On July 12, 2015, 4:41 a.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34908/
> -----------------------------------------------------------
> 
> (Updated July 12, 2015, 4:41 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Rename --docker_sandbox_directory flag for general use.
> 
> This will require users to update configuration scripts etc if they specify the old flag.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md feee5594c88112f77ce382cb3dd8628653f92d01 
>   src/slave/containerizer/docker.cpp cfb60177fe48ec0eeab12ff392c6c9f89634b92f 
>   src/slave/flags.hpp 26c778db2303167369af8675fe0441a00a1e9151 
>   src/slave/flags.cpp 8632677ebbdbfef8ffa45204b6f63a700baff7f3 
>   src/tests/docker_containerizer_tests.cpp a3da786c1b733e9dd4abf1d02d5dae051393d921 
> 
> Diff: https://reviews.apache.org/r/34908/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ian Downes
> 
>

Re: Review Request 34908: Rename --docker_sandbox_directory flag for general use.

Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34908/
-----------------------------------------------------------

(Updated July 11, 2015, 9:41 p.m.)


Review request for mesos and Timothy Chen.


Repository: mesos


Description
-------

Rename --docker_sandbox_directory flag for general use.

This will require users to update configuration scripts etc if they specify the old flag.


Diffs (updated)
-----

  docs/configuration.md feee5594c88112f77ce382cb3dd8628653f92d01 
  src/slave/containerizer/docker.cpp cfb60177fe48ec0eeab12ff392c6c9f89634b92f 
  src/slave/flags.hpp 26c778db2303167369af8675fe0441a00a1e9151 
  src/slave/flags.cpp 8632677ebbdbfef8ffa45204b6f63a700baff7f3 
  src/tests/docker_containerizer_tests.cpp a3da786c1b733e9dd4abf1d02d5dae051393d921 

Diff: https://reviews.apache.org/r/34908/diff/


Testing
-------


Thanks,

Ian Downes

Re: Review Request 34908: Rename --docker_sandbox_directory flag for general use.

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34908/#review91369
-----------------------------------------------------------

Ship it!


Ship It!


docs/configuration.md (line 933)
<https://reviews.apache.org/r/34908/#comment144737>

    Can we go through a depcreation cycle for this flag? I'm not 100% sure who's using this but we should give users a warning and remove it at the following version.


- Timothy Chen


On June 22, 2015, 4:55 p.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34908/
> -----------------------------------------------------------
> 
> (Updated June 22, 2015, 4:55 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Rename --docker_sandbox_directory flag for general use.
> 
> This will require users to update configuration scripts etc if they specify the old flag.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md aaf65bfa2848318c8d07c772ba2c521aa72c2677 
>   src/slave/containerizer/docker.cpp 00db9811824995fe19a6143aa2bcba3733a93147 
>   src/slave/flags.hpp 7634e368c72e83932dcd992d78eaca146326606b 
>   src/slave/flags.cpp cbf431eb0627bdaf07241cc0fc4630df06fb20e2 
>   src/tests/docker_containerizer_tests.cpp 3a983c6813dab6fa03ccb2c87e1ea71866766d6e 
> 
> Diff: https://reviews.apache.org/r/34908/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ian Downes
> 
>

Re: Review Request 34908: Rename --docker_sandbox_directory flag for general use.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34908/#review88833
-----------------------------------------------------------


Patch looks great!

Reviews applied: [34908]

All tests passed.

- Mesos ReviewBot


On June 22, 2015, 4:55 p.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34908/
> -----------------------------------------------------------
> 
> (Updated June 22, 2015, 4:55 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Rename --docker_sandbox_directory flag for general use.
> 
> This will require users to update configuration scripts etc if they specify the old flag.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md aaf65bfa2848318c8d07c772ba2c521aa72c2677 
>   src/slave/containerizer/docker.cpp 00db9811824995fe19a6143aa2bcba3733a93147 
>   src/slave/flags.hpp 7634e368c72e83932dcd992d78eaca146326606b 
>   src/slave/flags.cpp cbf431eb0627bdaf07241cc0fc4630df06fb20e2 
>   src/tests/docker_containerizer_tests.cpp 3a983c6813dab6fa03ccb2c87e1ea71866766d6e 
> 
> Diff: https://reviews.apache.org/r/34908/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ian Downes
> 
>

Re: Review Request 34908: Rename --docker_sandbox_directory flag for general use.

Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34908/
-----------------------------------------------------------

(Updated June 22, 2015, 9:55 a.m.)


Review request for mesos and Timothy Chen.


Repository: mesos


Description
-------

Rename --docker_sandbox_directory flag for general use.

This will require users to update configuration scripts etc if they specify the old flag.


Diffs (updated)
-----

  docs/configuration.md aaf65bfa2848318c8d07c772ba2c521aa72c2677 
  src/slave/containerizer/docker.cpp 00db9811824995fe19a6143aa2bcba3733a93147 
  src/slave/flags.hpp 7634e368c72e83932dcd992d78eaca146326606b 
  src/slave/flags.cpp cbf431eb0627bdaf07241cc0fc4630df06fb20e2 
  src/tests/docker_containerizer_tests.cpp 3a983c6813dab6fa03ccb2c87e1ea71866766d6e 

Diff: https://reviews.apache.org/r/34908/diff/


Testing
-------


Thanks,

Ian Downes

Re: Review Request 34908: Rename --docker_sandbox_directory flag for general use.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34908/#review86115
-----------------------------------------------------------


Patch looks great!

Reviews applied: [34908]

All tests passed.

- Mesos ReviewBot


On June 1, 2015, 9:48 p.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34908/
> -----------------------------------------------------------
> 
> (Updated June 1, 2015, 9:48 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Rename --docker_sandbox_directory flag for general use.
> 
> This will require users to update configuration scripts etc if they specify the old flag.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 4e20913cf7a088997235f399733c89db3441fb7c 
>   src/slave/containerizer/docker.cpp 41e0b98c387e57b692df4c56ae21ce70f67f9a19 
>   src/slave/flags.hpp 84dbb8a2aa963bb38cf0f610ab442b626179b173 
>   src/slave/flags.cpp ab8709861eb037e75dd2e91a097048ea6cd20c9c 
>   src/tests/docker_containerizer_tests.cpp 3a983c6813dab6fa03ccb2c87e1ea71866766d6e 
> 
> Diff: https://reviews.apache.org/r/34908/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ian Downes
> 
>

Re: Review Request 34908: Rename --docker_sandbox_directory flag for general use.

Posted by Ian Downes <ia...@gmail.com>.

> On June 15, 2015, 6:32 p.m., Till Toenshoff wrote:
> > docs/configuration.md, line 920
> > <https://reviews.apache.org/r/34908/diff/1/?file=975934#file975934line920>
> >
> >     Do you have a followup planned that also updates "docs/upgrades.md" on this configuration change?

Yes, I'll add this when we cut a release.


- Ian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34908/#review88016
-----------------------------------------------------------


On June 1, 2015, 2:48 p.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34908/
> -----------------------------------------------------------
> 
> (Updated June 1, 2015, 2:48 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Rename --docker_sandbox_directory flag for general use.
> 
> This will require users to update configuration scripts etc if they specify the old flag.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 4e20913cf7a088997235f399733c89db3441fb7c 
>   src/slave/containerizer/docker.cpp 41e0b98c387e57b692df4c56ae21ce70f67f9a19 
>   src/slave/flags.hpp 84dbb8a2aa963bb38cf0f610ab442b626179b173 
>   src/slave/flags.cpp ab8709861eb037e75dd2e91a097048ea6cd20c9c 
>   src/tests/docker_containerizer_tests.cpp 3a983c6813dab6fa03ccb2c87e1ea71866766d6e 
> 
> Diff: https://reviews.apache.org/r/34908/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ian Downes
> 
>

Re: Review Request 34908: Rename --docker_sandbox_directory flag for general use.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34908/#review88016
-----------------------------------------------------------

Ship it!



docs/configuration.md
<https://reviews.apache.org/r/34908/#comment140422>

    Do you have a followup planned that also updates "docs/upgrades.md" on this configuration change?


- Till Toenshoff


On June 1, 2015, 9:48 p.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34908/
> -----------------------------------------------------------
> 
> (Updated June 1, 2015, 9:48 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Rename --docker_sandbox_directory flag for general use.
> 
> This will require users to update configuration scripts etc if they specify the old flag.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 4e20913cf7a088997235f399733c89db3441fb7c 
>   src/slave/containerizer/docker.cpp 41e0b98c387e57b692df4c56ae21ce70f67f9a19 
>   src/slave/flags.hpp 84dbb8a2aa963bb38cf0f610ab442b626179b173 
>   src/slave/flags.cpp ab8709861eb037e75dd2e91a097048ea6cd20c9c 
>   src/tests/docker_containerizer_tests.cpp 3a983c6813dab6fa03ccb2c87e1ea71866766d6e 
> 
> Diff: https://reviews.apache.org/r/34908/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ian Downes
> 
>