[GitHub] [couchdb] eiri commented on issue #2522: Strip credentials from the traces we send to open tracing server.

[GitBox <gi...@apache.org>]

eiri commented on issue #2522: Strip credentials from the traces we send to open tracing server.
URL: https://github.com/apache/couchdb/pull/2522#issuecomment-582442839
 
 
   This doesn't strike me as a proper fix. I don't know what admin creds are doing in fdb connection  string in a first place, but you are altering behaviour of server module's `init` to addresscan auxiliary tool's problem. I'll defer decision to @davisp who has more solid idea of what's going on here, but to me this looks rather backwards.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services