[GitHub] [ozone] adoroszlai commented on pull request #3553: HDDS-6942. Ozone Vols/Buckets/Objects created via S3 should not allow group access

[GitBox <gi...@apache.org>]

adoroszlai commented on PR #3553:
URL: https://github.com/apache/ozone/pull/3553#issuecomment-1168278438

   > The Client and it's cache should avoid deciding defaults for the requests.
   
   I was concerned that the setting may not be effective, as the client may already be created when endpoint's `initialization()` is called (since client needs to be injected).  Now that @neils-dev pointed to `OzoneConfigurationHolder`, I see that the original approach works because the same instance of `OzoneConfiguration` is shared in S3 Gateway for all injections.
   
   Can you please add an assertion for the expected ACL in S3 smoketests?  `hadoop-ozone/dist/src/main/smoketest/s3/bucketcreate.robot` or `hadoop-ozone/dist/src/main/smoketest/security/ozone-secure-s3.robot` might be a good candidate for that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org