You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Matthew Gilliard (JIRA)" <ji...@codehaus.org> on 2010/12/11 00:29:57 UTC

[jira] Created: (SUREFIRE-663) Allow custom Junit4 RunListeners to be specified

Allow custom Junit4 RunListeners to be specified
------------------------------------------------

                 Key: SUREFIRE-663
                 URL: http://jira.codehaus.org/browse/SUREFIRE-663
             Project: Maven Surefire
          Issue Type: New Feature
          Components: Junit 4.x support
    Affects Versions: 2.6
            Reporter: Matthew Gilliard
         Attachments: surefire_junit4_listener.patch

It would be nice to allow listing of FQCNs of Junit4 RunListeners in user's pom.xml so that they can add their own custom RunListeners.  Syntax would be the same as for TestNG, ie:

<configuration>
  <property>
    <name>listener</name>
    <value>list,of,FQCNs,implementing,org.junit.runner.notification.RunListener</value>
  ...

patch attached for surefire-junit4

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (SUREFIRE-663) Allow custom Junit4 RunListeners to be specified

Posted by "Kristian Rosenvold (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SUREFIRE-663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=247282#action_247282 ] 

Kristian Rosenvold commented on SUREFIRE-663:
---------------------------------------------

Actually there is an It for the corresponding testng feature that can be used/expanded. Use search to find it. 

> Allow custom Junit4 RunListeners to be specified
> ------------------------------------------------
>
>                 Key: SUREFIRE-663
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-663
>             Project: Maven Surefire
>          Issue Type: New Feature
>          Components: Junit 4.x support
>    Affects Versions: 2.6
>            Reporter: Matthew Gilliard
>         Attachments: surefire_junit4_listener.patch
>
>
> It would be nice to allow listing of FQCNs of Junit4 RunListeners in user's pom.xml so that they can add their own custom RunListeners.  Syntax would be the same as for TestNG, ie:
> <configuration>
>   <property>
>     <name>listener</name>
>     <value>list,of,FQCNs,implementing,org.junit.runner.notification.RunListener</value>
>   ...
> patch attached for surefire-junit4

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (SUREFIRE-663) Allow custom Junit4 RunListeners to be specified

Posted by "Kristian Rosenvold (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SUREFIRE-663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Rosenvold closed SUREFIRE-663.
---------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.7
         Assignee: Kristian Rosenvold

Patch applied with modifications (added 4.7 provider too) in r1045052. Thanks !

> Allow custom Junit4 RunListeners to be specified
> ------------------------------------------------
>
>                 Key: SUREFIRE-663
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-663
>             Project: Maven Surefire
>          Issue Type: New Feature
>          Components: Junit 4.x support
>    Affects Versions: 2.6
>            Reporter: Matthew Gilliard
>            Assignee: Kristian Rosenvold
>             Fix For: 2.7
>
>         Attachments: surefire-integration-test.patch, surefire-integration-test.patch, surefire_junit4_listener.patch, surefire_junit4_listener.patch
>
>
> It would be nice to allow listing of FQCNs of Junit4 RunListeners in user's pom.xml so that they can add their own custom RunListeners.  Syntax would be the same as for TestNG, ie:
> <configuration>
>   <property>
>     <name>listener</name>
>     <value>list,of,FQCNs,implementing,org.junit.runner.notification.RunListener</value>
>   ...
> patch attached for surefire-junit4

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (SUREFIRE-663) Allow custom Junit4 RunListeners to be specified

Posted by "Kristian Rosenvold (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SUREFIRE-663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=247279#action_247279 ] 

Kristian Rosenvold commented on SUREFIRE-663:
---------------------------------------------

The patch reformats the code in a code-standard that is not ASF. Also an integration test is a requirement. There is a org.apache.maven.surefire.junitcore.DiagnosticRunListener that should be usable to make an IT (it's in the 4.7 provider, you should be able to include that as a dependency within the actual IT)

Have a look at for instance surefire-integration-tests/src/test/resources/surefire-408-manual-provider-selection and the accompanying Surefire408ManualProviderSelectionIT.java for a nice starting point. 




> Allow custom Junit4 RunListeners to be specified
> ------------------------------------------------
>
>                 Key: SUREFIRE-663
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-663
>             Project: Maven Surefire
>          Issue Type: New Feature
>          Components: Junit 4.x support
>    Affects Versions: 2.6
>            Reporter: Matthew Gilliard
>         Attachments: surefire_junit4_listener.patch
>
>
> It would be nice to allow listing of FQCNs of Junit4 RunListeners in user's pom.xml so that they can add their own custom RunListeners.  Syntax would be the same as for TestNG, ie:
> <configuration>
>   <property>
>     <name>listener</name>
>     <value>list,of,FQCNs,implementing,org.junit.runner.notification.RunListener</value>
>   ...
> patch attached for surefire-junit4

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (SUREFIRE-663) Allow custom Junit4 RunListeners to be specified

Posted by "Matthew Gilliard (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SUREFIRE-663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthew Gilliard updated SUREFIRE-663:
--------------------------------------

    Attachment: surefire-integration-test.patch

Couple of files missing from the first patch, sorry.

> Allow custom Junit4 RunListeners to be specified
> ------------------------------------------------
>
>                 Key: SUREFIRE-663
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-663
>             Project: Maven Surefire
>          Issue Type: New Feature
>          Components: Junit 4.x support
>    Affects Versions: 2.6
>            Reporter: Matthew Gilliard
>         Attachments: surefire-integration-test.patch, surefire-integration-test.patch, surefire_junit4_listener.patch, surefire_junit4_listener.patch
>
>
> It would be nice to allow listing of FQCNs of Junit4 RunListeners in user's pom.xml so that they can add their own custom RunListeners.  Syntax would be the same as for TestNG, ie:
> <configuration>
>   <property>
>     <name>listener</name>
>     <value>list,of,FQCNs,implementing,org.junit.runner.notification.RunListener</value>
>   ...
> patch attached for surefire-junit4

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (SUREFIRE-663) Allow custom Junit4 RunListeners to be specified

Posted by "Matthew Gilliard (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SUREFIRE-663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthew Gilliard updated SUREFIRE-663:
--------------------------------------

    Attachment: surefire-integration-test.patch
                surefire_junit4_listener.patch

Fixed formatting for surefire-junit4 patch
Added surefire-integration-test patch

> Allow custom Junit4 RunListeners to be specified
> ------------------------------------------------
>
>                 Key: SUREFIRE-663
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-663
>             Project: Maven Surefire
>          Issue Type: New Feature
>          Components: Junit 4.x support
>    Affects Versions: 2.6
>            Reporter: Matthew Gilliard
>         Attachments: surefire-integration-test.patch, surefire_junit4_listener.patch, surefire_junit4_listener.patch
>
>
> It would be nice to allow listing of FQCNs of Junit4 RunListeners in user's pom.xml so that they can add their own custom RunListeners.  Syntax would be the same as for TestNG, ie:
> <configuration>
>   <property>
>     <name>listener</name>
>     <value>list,of,FQCNs,implementing,org.junit.runner.notification.RunListener</value>
>   ...
> patch attached for surefire-junit4

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira