[GitHub] [pulsar] eolivelli commented on a change in pull request #9232: Allow to configure BookKeeper Opportunistic Striping Feature

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #9232:
URL: https://github.com/apache/pulsar/pull/9232#discussion_r559802595



##########
File path: conf/broker.conf
##########
@@ -800,6 +800,10 @@ managedLedgerDefaultWriteQuorum=2
 # Number of guaranteed copies (acks to wait before write is complete)
 managedLedgerDefaultAckQuorum=2
 
+# with OpportunisticStriping=true the ensembleSize is adapted automatically to writeQuorum
+# in case of lack of enough bookies
+bookkeeperOpportunisticStriping=false

Review comment:
       I am open to switch to a new mode of configuring the internal BK client.
   
   If I understand correctly currently in Pulsar community we prefer to allow only a limited and known set of BK configuration options in order to have total control over which feature of BK can be safely used and that we are officially supporting in Pulsar 
   
   If we let any configuration option to be activated users could fall into bad conditions that are not supposed to happen in Pulsar.
   
   Can you confirm that a more generic approach is what we want?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org