[jira] [Commented] (TINKERPOP-1814) Some process tests require the graph API

["Marko A. Rodriguez (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234248#comment-16234248 ] 

Marko A. Rodriguez commented on TINKERPOP-1814:
-----------------------------------------------

Yes, these tests should not do this. Once in the process test suite, we should assume {{ReferenceElement}} accessible data at most. If more data is required, then another traversal should be spawned. This way process doesn't leak into structure.



> Some process tests require the graph API
> ----------------------------------------
>
>                 Key: TINKERPOP-1814
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1814
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.2.6
>            Reporter: Bryn Cooke
>            Priority: Major
>
> This test uses the graph API:
> https://github.com/apache/tinkerpop/blob/master/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/AddEdgeTest.java#L137-L142
> This test assumes that the reference to the vertex will be updated. It should at least fetch the vertex again after it has been updated, but ideally use a traversal for verification.
> https://github.com/apache/tinkerpop/blob/master/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/decoration/PartitionStrategyProcessTest.java#L142-L143
> These tests disable the strategies supplied by the implementing graph and therefore they will default to using the graph API under the hood.
> https://github.com/apache/tinkerpop/blob/master/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/CoreTraversalTest.java#L222-L261



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)