You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Kirk Lund <ki...@gmail.com> on 2016/03/15 01:54:35 UTC
Review Request 44818: GEODE-949: refactor test security
implementation PART 1 of 2
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44818/
-----------------------------------------------------------
Review request for geode, Jens Deppe and Jinmei Liao.
Bugs: GEODE-949
https://issues.apache.org/jira/browse/GEODE-949
Repository: geode
Description
-------
This is PART 1 of 2. These changes involve only extensive reformatting of the classes, renaming of variables and fixing up javadocs (including removal of @author tags). These changes are in test code only.?
I'd like to review and commit this separately from PART 2 of 2 which will move all of these classes to a new package.
Diffs
-----
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/DurableClientBug39997DUnitTest.java fb8fb3e
geode-core/src/test/java/security/AuthzCredentialGenerator.java fdd10b0
geode-core/src/test/java/security/CredentialGenerator.java 475cefa
geode-core/src/test/java/security/DummyAuthzCredentialGenerator.java 8496be3
geode-core/src/test/java/security/DummyCredentialGenerator.java 5419587
geode-core/src/test/java/security/LdapUserCredentialGenerator.java 2b95616
geode-core/src/test/java/security/PKCSCredentialGenerator.java 5b6d5fa
geode-core/src/test/java/security/SSLCredentialGenerator.java e547630
geode-core/src/test/java/security/UserPasswordWithExtraPropsAuthInit.java cc585cd
geode-core/src/test/java/security/XmlAuthzCredentialGenerator.java 118e86f
geode-core/src/test/java/templates/security/DummyAuthenticator.java 5070836
geode-core/src/test/java/templates/security/DummyAuthorization.java 4c2bfec
geode-core/src/test/java/templates/security/FunctionSecurityPrmsHolder.java 5771fd4
geode-core/src/test/java/templates/security/LdapUserAuthenticator.java 49059c3
geode-core/src/test/java/templates/security/PKCSAuthInit.java f4004f3
geode-core/src/test/java/templates/security/PKCSAuthenticator.java 7af7312
geode-core/src/test/java/templates/security/PKCSPrincipal.java bc3049f
geode-core/src/test/java/templates/security/UserPasswordAuthInit.java 1c48773
geode-core/src/test/java/templates/security/UsernamePrincipal.java 781dd5a
geode-core/src/test/java/templates/security/XmlAuthorization.java 29d94de
geode-core/src/test/java/templates/security/XmlErrorHandler.java 1326548
Diff: https://reviews.apache.org/r/44818/diff/
Testing
-------
precheckin
additional end-to-end security hydra tests
Thanks,
Kirk Lund
Re: Review Request 44818: GEODE-949: refactor test security
implementation PART 1 of 2
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44818/#review123739
-----------------------------------------------------------
Ship it!
Ship It!
- Jinmei Liao
On March 15, 2016, 12:56 a.m., Kirk Lund wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44818/
> -----------------------------------------------------------
>
> (Updated March 15, 2016, 12:56 a.m.)
>
>
> Review request for geode, Jens Deppe and Jinmei Liao.
>
>
> Bugs: GEODE-949
> https://issues.apache.org/jira/browse/GEODE-949
>
>
> Repository: geode
>
>
> Description
> -------
>
> This is PART 1 of 2. These changes involve only extensive reformatting of the classes, renaming of variables and fixing up javadocs (including removal of @author tags). These changes are in test code only.?
>
> I'd like to review and commit this separately from PART 2 of 2 which will move all of these classes to a new package.
>
> The changes in DurableClientBug39997DUnitTest are unrelated to security but are present because of some testing I was doing while working on this branch.
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/DurableClientBug39997DUnitTest.java fb8fb3e
> geode-core/src/test/java/security/AuthzCredentialGenerator.java fdd10b0
> geode-core/src/test/java/security/CredentialGenerator.java 475cefa
> geode-core/src/test/java/security/DummyAuthzCredentialGenerator.java 8496be3
> geode-core/src/test/java/security/DummyCredentialGenerator.java 5419587
> geode-core/src/test/java/security/LdapUserCredentialGenerator.java 2b95616
> geode-core/src/test/java/security/PKCSCredentialGenerator.java 5b6d5fa
> geode-core/src/test/java/security/SSLCredentialGenerator.java e547630
> geode-core/src/test/java/security/UserPasswordWithExtraPropsAuthInit.java cc585cd
> geode-core/src/test/java/security/XmlAuthzCredentialGenerator.java 118e86f
> geode-core/src/test/java/templates/security/DummyAuthenticator.java 5070836
> geode-core/src/test/java/templates/security/DummyAuthorization.java 4c2bfec
> geode-core/src/test/java/templates/security/FunctionSecurityPrmsHolder.java 5771fd4
> geode-core/src/test/java/templates/security/LdapUserAuthenticator.java 49059c3
> geode-core/src/test/java/templates/security/PKCSAuthInit.java f4004f3
> geode-core/src/test/java/templates/security/PKCSAuthenticator.java 7af7312
> geode-core/src/test/java/templates/security/PKCSPrincipal.java bc3049f
> geode-core/src/test/java/templates/security/UserPasswordAuthInit.java 1c48773
> geode-core/src/test/java/templates/security/UsernamePrincipal.java 781dd5a
> geode-core/src/test/java/templates/security/XmlAuthorization.java 29d94de
> geode-core/src/test/java/templates/security/XmlErrorHandler.java 1326548
>
> Diff: https://reviews.apache.org/r/44818/diff/
>
>
> Testing
> -------
>
> precheckin
> additional end-to-end security hydra tests
>
>
> Thanks,
>
> Kirk Lund
>
>
Re: Review Request 44818: GEODE-949: refactor test security
implementation PART 1 of 2
Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44818/#review123737
-----------------------------------------------------------
Ship it!
Ship It!
- Jens Deppe
On March 15, 2016, 12:56 a.m., Kirk Lund wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44818/
> -----------------------------------------------------------
>
> (Updated March 15, 2016, 12:56 a.m.)
>
>
> Review request for geode, Jens Deppe and Jinmei Liao.
>
>
> Bugs: GEODE-949
> https://issues.apache.org/jira/browse/GEODE-949
>
>
> Repository: geode
>
>
> Description
> -------
>
> This is PART 1 of 2. These changes involve only extensive reformatting of the classes, renaming of variables and fixing up javadocs (including removal of @author tags). These changes are in test code only.?
>
> I'd like to review and commit this separately from PART 2 of 2 which will move all of these classes to a new package.
>
> The changes in DurableClientBug39997DUnitTest are unrelated to security but are present because of some testing I was doing while working on this branch.
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/DurableClientBug39997DUnitTest.java fb8fb3e
> geode-core/src/test/java/security/AuthzCredentialGenerator.java fdd10b0
> geode-core/src/test/java/security/CredentialGenerator.java 475cefa
> geode-core/src/test/java/security/DummyAuthzCredentialGenerator.java 8496be3
> geode-core/src/test/java/security/DummyCredentialGenerator.java 5419587
> geode-core/src/test/java/security/LdapUserCredentialGenerator.java 2b95616
> geode-core/src/test/java/security/PKCSCredentialGenerator.java 5b6d5fa
> geode-core/src/test/java/security/SSLCredentialGenerator.java e547630
> geode-core/src/test/java/security/UserPasswordWithExtraPropsAuthInit.java cc585cd
> geode-core/src/test/java/security/XmlAuthzCredentialGenerator.java 118e86f
> geode-core/src/test/java/templates/security/DummyAuthenticator.java 5070836
> geode-core/src/test/java/templates/security/DummyAuthorization.java 4c2bfec
> geode-core/src/test/java/templates/security/FunctionSecurityPrmsHolder.java 5771fd4
> geode-core/src/test/java/templates/security/LdapUserAuthenticator.java 49059c3
> geode-core/src/test/java/templates/security/PKCSAuthInit.java f4004f3
> geode-core/src/test/java/templates/security/PKCSAuthenticator.java 7af7312
> geode-core/src/test/java/templates/security/PKCSPrincipal.java bc3049f
> geode-core/src/test/java/templates/security/UserPasswordAuthInit.java 1c48773
> geode-core/src/test/java/templates/security/UsernamePrincipal.java 781dd5a
> geode-core/src/test/java/templates/security/XmlAuthorization.java 29d94de
> geode-core/src/test/java/templates/security/XmlErrorHandler.java 1326548
>
> Diff: https://reviews.apache.org/r/44818/diff/
>
>
> Testing
> -------
>
> precheckin
> additional end-to-end security hydra tests
>
>
> Thanks,
>
> Kirk Lund
>
>
Re: Review Request 44818: GEODE-949: refactor test security
implementation PART 1 of 2
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44818/
-----------------------------------------------------------
(Updated March 15, 2016, 12:56 a.m.)
Review request for geode, Jens Deppe and Jinmei Liao.
Bugs: GEODE-949
https://issues.apache.org/jira/browse/GEODE-949
Repository: geode
Description (updated)
-------
This is PART 1 of 2. These changes involve only extensive reformatting of the classes, renaming of variables and fixing up javadocs (including removal of @author tags). These changes are in test code only.?
I'd like to review and commit this separately from PART 2 of 2 which will move all of these classes to a new package.
The changes in DurableClientBug39997DUnitTest are unrelated to security but are present because of some testing I was doing while working on this branch.
Diffs
-----
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/DurableClientBug39997DUnitTest.java fb8fb3e
geode-core/src/test/java/security/AuthzCredentialGenerator.java fdd10b0
geode-core/src/test/java/security/CredentialGenerator.java 475cefa
geode-core/src/test/java/security/DummyAuthzCredentialGenerator.java 8496be3
geode-core/src/test/java/security/DummyCredentialGenerator.java 5419587
geode-core/src/test/java/security/LdapUserCredentialGenerator.java 2b95616
geode-core/src/test/java/security/PKCSCredentialGenerator.java 5b6d5fa
geode-core/src/test/java/security/SSLCredentialGenerator.java e547630
geode-core/src/test/java/security/UserPasswordWithExtraPropsAuthInit.java cc585cd
geode-core/src/test/java/security/XmlAuthzCredentialGenerator.java 118e86f
geode-core/src/test/java/templates/security/DummyAuthenticator.java 5070836
geode-core/src/test/java/templates/security/DummyAuthorization.java 4c2bfec
geode-core/src/test/java/templates/security/FunctionSecurityPrmsHolder.java 5771fd4
geode-core/src/test/java/templates/security/LdapUserAuthenticator.java 49059c3
geode-core/src/test/java/templates/security/PKCSAuthInit.java f4004f3
geode-core/src/test/java/templates/security/PKCSAuthenticator.java 7af7312
geode-core/src/test/java/templates/security/PKCSPrincipal.java bc3049f
geode-core/src/test/java/templates/security/UserPasswordAuthInit.java 1c48773
geode-core/src/test/java/templates/security/UsernamePrincipal.java 781dd5a
geode-core/src/test/java/templates/security/XmlAuthorization.java 29d94de
geode-core/src/test/java/templates/security/XmlErrorHandler.java 1326548
Diff: https://reviews.apache.org/r/44818/diff/
Testing
-------
precheckin
additional end-to-end security hydra tests
Thanks,
Kirk Lund