[GitHub] [iceberg] openinx commented on issue #1176: scala version of dependencies.lock is incorrect in iceberg-flink

[GitBox <gi...@apache.org>]

openinx commented on issue #1176:
URL: https://github.com/apache/iceberg/issues/1176#issuecomment-654830244


   I think I made this mistake in PR 20651b1c,  I used the flink with scala 2.11 version firstly  and then we discussed to better to support scala 2.12, so I changed the flink module from scala 2.11 to scala 2.12 but forgot to re-generate the `dependencies.lock`. 
   
   IMO, we'd better to remove those `dependencies.lock` from git and change to re-generate them when building the iceberg modules, because: 
   1.  we don't have to remember to re-generate those lock files by handle after changed the dependencies jar/version;
   2. Git won't inflate because of those lock changes, in the last commit 20651b1c I commited a PR with 10000+ lines which make the changed lines untrue. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org