You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/01/04 18:53:55 UTC

[GitHub] [couchdb] wohali commented on a change in pull request #2390: feat: add metric counter for unindexed mango queries. Closes #1913

wohali commented on a change in pull request #2390: feat: add metric counter for unindexed mango queries. Closes #1913
URL: https://github.com/apache/couchdb/pull/2390#discussion_r363049504
 
 

 ##########
 File path: src/mango/src/mango_cursor.erl
 ##########
 @@ -182,6 +182,7 @@ maybe_add_warning_int(ok, _, UserAcc) ->
    UserAcc;
 
 maybe_add_warning_int(Warning, UserFun, UserAcc) ->
+    couch_stats:increment_counter([mango, unindexed_queries]),
 
 Review comment:
   Don't you need a `case` here to check if `UseIndexInvalidWarning` from above is actually `ok` (sourced from `NoIndexWarning`, in which case there wouldn't be a warning?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services