You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@avro.apache.org by "MarkPaxton (via GitHub)" <gi...@apache.org> on 2023/07/07 11:20:10 UTC

[GitHub] [avro] MarkPaxton opened a new pull request, #2325: AVRO-XXXX (JIRA pending) [java]: Fix comparison of Maps within GenericData (java).

MarkPaxton opened a new pull request, #2325:
URL: https://github.com/apache/avro/pull/2325

   ## What is the purpose of the change
   
   2 bugs in comparing Maps within GenericData: 
   * Comparison of size incorrectly compared map1 with map1 not map1 with map2. 
   * When maps are empty an exception is incorrectly thrown (iterator().next() fails in that instance).
   
   ## Verifying this change
   
   This change added unit tests for empty and mismatched size maps.
   
   ## Documentation
   
   - Does this pull request introduce a new feature? no


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] MarkPaxton closed pull request #2325: AVRO-3792 [java]: Fix comparison of Maps within GenericData (java).

Posted by "MarkPaxton (via GitHub)" <gi...@apache.org>.

MarkPaxton closed pull request #2325: AVRO-3792 [java]: Fix comparison of Maps within GenericData (java).
URL: https://github.com/apache/avro/pull/2325


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] MarkPaxton commented on pull request #2325: AVRO-3792 [java]: Fix comparison of Maps within GenericData (java).

Posted by "MarkPaxton (via GitHub)" <gi...@apache.org>.

MarkPaxton commented on PR #2325:
URL: https://github.com/apache/avro/pull/2325#issuecomment-1625378108

   Duplicated by https://github.com/apache/avro/pull/2318


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org