storm git commit: [STORM-2892] fix PATH substitution in flux tests

[sr...@apache.org]

Repository: storm
Updated Branches:
  refs/heads/1.x-branch 9fbe28387 -> 7afea5807


[STORM-2892] fix PATH substitution in flux tests

The tests fail when the PATH environment variable has a trailing colon, despite that being a valid PATH.
This happens because it is substituted directly into the resultant YAML file, which results in invalid
YAML (since you cannot end a map's value with ":" in the raw text).

So the solution is to wrap the map value with double-quotes.

Also fix 2 typos in comments in this file.


Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/7afea580
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/7afea580
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/7afea580

Branch: refs/heads/1.x-branch
Commit: 7afea58072d0c64020de258f930147f3f3171472
Parents: 9fbe283
Author: Erik Weathers <er...@gmail.com>
Authored: Tue Jan 9 22:10:42 2018 -0800
Committer: Stig Rohde Døssing <sr...@apache.org>
Committed: Fri Jan 12 20:47:43 2018 +0100

----------------------------------------------------------------------
 .../src/test/resources/configs/substitution-test.yaml          | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/storm/blob/7afea580/external/flux/flux-core/src/test/resources/configs/substitution-test.yaml
----------------------------------------------------------------------
diff --git a/external/flux/flux-core/src/test/resources/configs/substitution-test.yaml b/external/flux/flux-core/src/test/resources/configs/substitution-test.yaml
index 3d521e1..9707936 100644
--- a/external/flux/flux-core/src/test/resources/configs/substitution-test.yaml
+++ b/external/flux/flux-core/src/test/resources/configs/substitution-test.yaml
@@ -22,7 +22,7 @@
 name: "${topology.name}"
 
 # Components
-# Components are analagous to Spring beans. They are meant to be used as constructor,
+# Components are analogous to Spring beans. They are meant to be used as constructor,
 # property(setter), and builder arguments.
 #components:
 #  - id: "myComponent"
@@ -41,8 +41,8 @@ name: "${topology.name}"
 #
 config:
   topology.workers: 1
-  # test environent variable substitution
-  test.env.value: ${ENV-PATH}
+  # test environment variable substitution
+  test.env.value: "${ENV-PATH}"
   # test variable substitution for list type
   list.property.target: ${a.list.property}