You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2016/12/17 22:50:07 UTC
Review Request 54842: Updated Resources to handle
Resource.AllocationInfo.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54842/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Jay Guo, and Guangya Liu.
Repository: mesos
Description
-------
With the addition of `Resource.AllocationInfo`, we must prevent the
loss of allocation information when performing addition and
subtraction of resources.
Diffs
-----
src/common/resources.cpp 16f6de6741b548a8a9fff5b70447b1a312f10efe
src/tests/resources_tests.cpp c0ff9777ceb1731086179e2966b07c46d035c110
src/v1/resources.cpp a1adf1b27964bf6a89d97715cff05878d8c6cae9
Diff: https://reviews.apache.org/r/54842/diff/
Testing
-------
Added tests.
Thanks,
Benjamin Mahler
Re: Review Request 54842: Updated Resources to handle
Resource.AllocationInfo.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54842/#review159563
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On \u5341\u4e8c\u6708 17, 2016, 10:50 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54842/
> -----------------------------------------------------------
>
> (Updated \u5341\u4e8c\u6708 17, 2016, 10:50 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jay Guo, and Guangya Liu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With the addition of `Resource.AllocationInfo`, we must prevent the
> loss of allocation information when performing addition and
> subtraction of resources.
>
>
> Diffs
> -----
>
> src/common/resources.cpp 16f6de6741b548a8a9fff5b70447b1a312f10efe
> src/tests/resources_tests.cpp c0ff9777ceb1731086179e2966b07c46d035c110
> src/v1/resources.cpp a1adf1b27964bf6a89d97715cff05878d8c6cae9
>
> Diff: https://reviews.apache.org/r/54842/diff/
>
>
> Testing
> -------
>
> Added tests.
>
>
> Thanks,
>
> Benjamin Mahler
>
>