You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/05/25 13:21:07 UTC

[GitHub] [pulsar] eolivelli opened a new pull request #10700: AutoConsumeSchema: use decode(payload, schemaversion)

eolivelli opened a new pull request #10700:
URL: https://github.com/apache/pulsar/pull/10700


   In `AutoConsumeSchema.decode `we should proxy the call to "`decode(payload, schemaversion)`" correctly to the wrapped Schema.
   
   Even if the Schema is picked up from a map (`schemaMap`) that keeps track of the _schemaversion_, we must pass the correct `schemaversion` to the underlying Schema.
   
   Some Schema implementations may fall back to using the "latest schema" if you pass "null" as _schemaversion_ or call `decode(payload)` (without _schemaversion_), leading to non consistent behaviour


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui merged pull request #10700: AutoConsumeSchema: use decode(payload, schemaversion)

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #10700:
URL: https://github.com/apache/pulsar/pull/10700


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org