[GitHub] [beam] timrobertson100 commented on a change in pull request #13027: [BEAM-5589][BEAM-5590][BEAM-5591] Update Solr dependencies from 5.5.4 to 8.5.2

[GitBox <gi...@apache.org>]

timrobertson100 commented on a change in pull request #13027:
URL: https://github.com/apache/beam/pull/13027#discussion_r502385742



##########
File path: sdks/java/io/solr/src/test/java/org/apache/beam/sdk/io/solr/SolrIOTestUtils.java
##########
@@ -37,10 +37,8 @@ static void createCollection(
       String collection, int numShards, int replicationFactor, AuthorizedSolrClient client)
       throws Exception {
     CollectionAdminRequest.Create create =
-        new CollectionAdminRequest.Create()
-            .setCollectionName(collection)
-            .setNumShards(numShards)
-            .setReplicationFactor(replicationFactor)
+        CollectionAdminRequest.Create.createCollection(
+                collection, null, numShards, replicationFactor)

Review comment:
       Nit: can this use `public static Create createCollection(String collection, int numShards, int numReplicas)` to avoid `null`
   
   https://github.com/apache/lucene-solr/blob/master/solr/solrj/src/java/org/apache/solr/client/solrj/request/CollectionAdminRequest.java#L395




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org