[jira] [Updated] (OOZIE-1838) jdbc.connections.active sampler does not show up

["Robert Kanter (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OOZIE-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Kanter updated OOZIE-1838:
---------------------------------

    Attachment: OOZIE-1838.patch

The problem was that in InstrumentedBasicDataSource (a subclass of Commons' BasicDataSource), in the constructor we were seeing if there was an InstrumentationService and then adding the sampler.  However, due to the order that things get loaded in, this was not available at that time so the sampler was never added.

The patch moves adding the sampler to the JPAService.  Unfortunately, getting the BasicDataSource object here was a little messy.  I also added a second sampler for the number of idle connections while I was at it.  And once I moved the sampler, InstrumentedBasicDataSource wasn't doing anything at all, so I removed it and replaced all references to it with BasicDataSource.  No tests, but I verified that the samplers now show up and appear to be working.

> jdbc.connections.active sampler does not show up
> ------------------------------------------------
>
>                 Key: OOZIE-1838
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1838
>             Project: Oozie
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 4.0.0
>            Reporter: Robert Kanter
>            Assignee: Robert Kanter
>         Attachments: OOZIE-1838.patch
>
>
> I'm not sure how long this has been missing, but I don't ever remember seeing a "jdbc.connections.active" sampler in the instrumentation.  However, I did stumble upon it in the code.  It's supposed to sample the number of active JDBC connections.



--
This message was sent by Atlassian JIRA
(v6.2#6252)