You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hugegraph.apache.org by GitBox <gi...@apache.org> on 2022/04/24 11:08:01 UTC
[GitHub] [incubator-hugegraph] Fizell opened a new pull request, #1845: fix hugegraph-api code checkstyle
Fizell opened a new pull request, #1845:
URL: https://github.com/apache/incubator-hugegraph/pull/1845
rt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] imbajin commented on a diff in pull request #1845: fix hugegraph-api code checkstyle
Posted by GitBox <gi...@apache.org>.
imbajin commented on code in PR #1845:
URL: https://github.com/apache/incubator-hugegraph/pull/1845#discussion_r857124766
##########
hugegraph-api/src/main/java/com/baidu/hugegraph/auth/StandardAuthenticator.java:
##########
@@ -95,7 +99,7 @@ private String inputPassword() {
if (!password.isEmpty()) {
return password;
}
- System.out.println(notEmptyPrompt);
+ LOG.info(notEmptyPrompt);
Review Comment:
seems it don't print in the log file (print on the console is right?) @javeme
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] imbajin commented on a diff in pull request #1845: fix hugegraph-api code checkstyle
Posted by GitBox <gi...@apache.org>.
imbajin commented on code in PR #1845:
URL: https://github.com/apache/incubator-hugegraph/pull/1845#discussion_r857248343
##########
hugegraph-api/src/main/java/com/baidu/hugegraph/auth/WsAndHttpBasicAuthHandler.java:
##########
@@ -155,7 +151,7 @@ public void channelRead(ChannelHandlerContext ctx, Object msg) {
private void sendError(ChannelHandlerContext ctx, Object msg) {
// Close the connection as soon as the error message is sent.
ctx.writeAndFlush(new DefaultFullHttpResponse(HTTP_1_1, UNAUTHORIZED))
- .addListener(ChannelFutureListener.CLOSE);
+ .addListener(ChannelFutureListener.CLOSE);
Review Comment:
> but the current style check specify that the code indented in multiples of 4，so we need to decide which style to use
yep, we'll discuss this issue in the developer group, ensure the rule
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] codecov[bot] commented on pull request #1845: fix hugegraph-api code checkstyle
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1845:
URL: https://github.com/apache/incubator-hugegraph/pull/1845#issuecomment-1107819599
# [Codecov](https://codecov.io/gh/apache/incubator-hugegraph/pull/1845?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1845](https://codecov.io/gh/apache/incubator-hugegraph/pull/1845?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f28f9bd) into [master](https://codecov.io/gh/apache/incubator-hugegraph/commit/9a8259ef3f22abf9781513b823a9f1096152d494?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9a8259e) will **decrease** coverage by `16.49%`.
> The diff coverage is `76.92%`.
```diff
@@ Coverage Diff @@
## master #1845 +/- ##
=============================================
- Coverage 66.93% 50.43% -16.50%
- Complexity 444 659 +215
=============================================
Files 446 446
Lines 37966 37948 -18
Branches 5410 5410
=============================================
- Hits 25413 19140 -6273
- Misses 9957 16519 +6562
+ Partials 2596 2289 -307
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hugegraph/pull/1845?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../java/com/baidu/hugegraph/api/auth/ProjectAPI.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1845/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWFwaS9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvYXBpL2F1dGgvUHJvamVjdEFQSS5qYXZh) | `82.05% <ø> (ø)` | |
| [...va/com/baidu/hugegraph/api/profile/ProfileAPI.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1845/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWFwaS9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvYXBpL3Byb2ZpbGUvUHJvZmlsZUFQSS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...aidu/hugegraph/auth/WsAndHttpBasicAuthHandler.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1845/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWFwaS9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvYXV0aC9Xc0FuZEh0dHBCYXNpY0F1dGhIYW5kbGVyLmphdmE=) | `58.62% <0.00%> (+1.47%)` | :arrow_up: |
| [...a/com/baidu/hugegraph/license/LicenseVerifier.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1845/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWFwaS9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvbGljZW5zZS9MaWNlbnNlVmVyaWZpZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...om/baidu/hugegraph/auth/StandardAuthenticator.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1845/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWFwaS9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvYXV0aC9TdGFuZGFyZEF1dGhlbnRpY2F0b3IuamF2YQ==) | `32.89% <50.00%> (-11.11%)` | :arrow_down: |
| [.../com/baidu/hugegraph/server/ApplicationConfig.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1845/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWFwaS9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvc2VydmVyL0FwcGxpY2F0aW9uQ29uZmlnLmphdmE=) | `93.02% <50.00%> (-0.46%)` | :arrow_down: |
| [...com/baidu/hugegraph/auth/HugeFactoryAuthProxy.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1845/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWFwaS9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvYXV0aC9IdWdlRmFjdG9yeUF1dGhQcm94eS5qYXZh) | `57.92% <62.50%> (+0.20%)` | :arrow_up: |
| [...va/com/baidu/hugegraph/auth/HugeAuthenticator.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1845/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWFwaS9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvYXV0aC9IdWdlQXV0aGVudGljYXRvci5qYXZh) | `40.10% <66.66%> (-0.11%)` | :arrow_down: |
| [.../java/com/baidu/hugegraph/metrics/MetricsUtil.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1845/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWFwaS9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvbWV0cmljcy9NZXRyaWNzVXRpbC5qYXZh) | `62.50% <66.66%> (ø)` | |
| [...api/src/main/java/com/baidu/hugegraph/api/API.java](https://codecov.io/gh/apache/incubator-hugegraph/pull/1845/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWFwaS9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvYXBpL0FQSS5qYXZh) | `74.11% <70.00%> (-0.89%)` | :arrow_down: |
| ... and [204 more](https://codecov.io/gh/apache/incubator-hugegraph/pull/1845/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hugegraph/pull/1845?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hugegraph/pull/1845?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9a8259e...f28f9bd](https://codecov.io/gh/apache/incubator-hugegraph/pull/1845?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] imbajin commented on a diff in pull request #1845: fix hugegraph-api code checkstyle
Posted by GitBox <gi...@apache.org>.
imbajin commented on code in PR #1845:
URL: https://github.com/apache/incubator-hugegraph/pull/1845#discussion_r857123884
##########
hugegraph-api/src/main/java/com/baidu/hugegraph/auth/WsAndHttpBasicAuthHandler.java:
##########
@@ -155,7 +151,7 @@ public void channelRead(ChannelHandlerContext ctx, Object msg) {
private void sendError(ChannelHandlerContext ctx, Object msg) {
// Close the connection as soon as the error message is sent.
ctx.writeAndFlush(new DefaultFullHttpResponse(HTTP_1_1, UNAUTHORIZED))
- .addListener(ChannelFutureListener.CLOSE);
+ .addListener(ChannelFutureListener.CLOSE);
Review Comment:
maybe we should keep the origin align?
##########
hugegraph-api/src/main/java/com/baidu/hugegraph/auth/WsAndHttpBasicAuthHandler.java:
##########
@@ -45,6 +27,23 @@
import io.netty.handler.codec.http.FullHttpMessage;
import io.netty.handler.codec.http.HttpMessage;
import io.netty.util.ReferenceCountUtil;
+import org.apache.tinkerpop.gremlin.server.Settings;
+import org.apache.tinkerpop.gremlin.server.auth.AuthenticationException;
+import org.apache.tinkerpop.gremlin.server.auth.Authenticator;
+import org.apache.tinkerpop.gremlin.server.handler.AbstractAuthenticationHandler;
+import org.apache.tinkerpop.gremlin.server.handler.SaslAuthenticationHandler;
+
+import java.nio.charset.StandardCharsets;
+import java.util.Base64;
+import java.util.HashMap;
+import java.util.Map;
+
+import static io.netty.handler.codec.http.HttpHeaderNames.CONNECTION;
+import static io.netty.handler.codec.http.HttpHeaderNames.UPGRADE;
+import static io.netty.handler.codec.http.HttpResponseStatus.UNAUTHORIZED;
+import static io.netty.handler.codec.http.HttpVersion.HTTP_1_1;
+import static org.apache.tinkerpop.gremlin.groovy.jsr223.dsl.credential.CredentialGraphTokens.PROPERTY_PASSWORD;
+import static org.apache.tinkerpop.gremlin.groovy.jsr223.dsl.credential.CredentialGraphTokens.PROPERTY_USERNAME;
Review Comment:
so as these import rules, u could refer the [style file](https://github.com/apache/incubator-hugegraph/blob/master/hugegraph-style.xml) in root dir to improve them
##########
hugegraph-api/src/main/java/com/baidu/hugegraph/auth/HugeGraphAuthProxy.java:
##########
@@ -1757,7 +1731,7 @@ public static class ContextThreadPoolExecutor extends ThreadPoolExecutor {
public ContextThreadPoolExecutor(int corePoolSize, int maxPoolSize,
ThreadFactory threadFactory) {
super(corePoolSize, maxPoolSize, 0L, TimeUnit.MILLISECONDS,
- new LinkedBlockingQueue<Runnable>(), threadFactory);
+ new LinkedBlockingQueue<>(), threadFactory);
Review Comment:
keep the origin align~
##########
hugegraph-api/src/main/java/com/baidu/hugegraph/auth/WsAndHttpBasicAuthHandler.java:
##########
@@ -114,19 +113,16 @@ public void channelRead(ChannelHandlerContext ctx, Object msg) {
sendError(ctx, msg);
return;
}
- byte[] userPass = null;
+ byte[] userPass;
try {
final String encoded = header.substring(basic.length());
userPass = this.decoder.decode(encoded);
- } catch (IndexOutOfBoundsException iae) {
- sendError(ctx, msg);
- return;
- } catch (IllegalArgumentException iae) {
+ } catch (IndexOutOfBoundsException | IllegalArgumentException iae) {
sendError(ctx, msg);
return;
}
String authorization = new String(userPass,
- Charset.forName("UTF-8"));
+ StandardCharsets.UTF_8);
Review Comment:
we use the `hugegraph-style` in the wiki (not java original style)
align the param with the highly priority
##########
hugegraph-api/src/main/java/com/baidu/hugegraph/auth/StandardAuthenticator.java:
##########
@@ -95,7 +99,7 @@ private String inputPassword() {
if (!password.isEmpty()) {
return password;
}
- System.out.println(notEmptyPrompt);
+ LOG.info(notEmptyPrompt);
Review Comment:
seems it was not print in the log file (print on the console is right?) @javeme
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] Fizell commented on pull request #1845: fix hugegraph-api code checkstyle
Posted by GitBox <gi...@apache.org>.
Fizell commented on PR #1845:
URL: https://github.com/apache/incubator-hugegraph/pull/1845#issuecomment-1108670171
seems that tends to keep the original align and keep original lambda style, so I submit a new PR to fix only some obvious style issues https://github.com/apache/incubator-hugegraph/pull/1851, and this PR will be closed @javeme @imbajin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] Fizell commented on a diff in pull request #1845: fix hugegraph-api code checkstyle
Posted by GitBox <gi...@apache.org>.
Fizell commented on code in PR #1845:
URL: https://github.com/apache/incubator-hugegraph/pull/1845#discussion_r857137693
##########
hugegraph-api/src/main/java/com/baidu/hugegraph/auth/HugeGraphAuthProxy.java:
##########
@@ -1757,7 +1731,7 @@ public static class ContextThreadPoolExecutor extends ThreadPoolExecutor {
public ContextThreadPoolExecutor(int corePoolSize, int maxPoolSize,
ThreadFactory threadFactory) {
super(corePoolSize, maxPoolSize, 0L, TimeUnit.MILLISECONDS,
- new LinkedBlockingQueue<Runnable>(), threadFactory);
+ new LinkedBlockingQueue<>(), threadFactory);
Review Comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] Fizell commented on a diff in pull request #1845: fix hugegraph-api code checkstyle
Posted by GitBox <gi...@apache.org>.
Fizell commented on code in PR #1845:
URL: https://github.com/apache/incubator-hugegraph/pull/1845#discussion_r857137398
##########
hugegraph-api/src/main/java/com/baidu/hugegraph/auth/WsAndHttpBasicAuthHandler.java:
##########
@@ -155,7 +151,7 @@ public void channelRead(ChannelHandlerContext ctx, Object msg) {
private void sendError(ChannelHandlerContext ctx, Object msg) {
// Close the connection as soon as the error message is sent.
ctx.writeAndFlush(new DefaultFullHttpResponse(HTTP_1_1, UNAUTHORIZED))
- .addListener(ChannelFutureListener.CLOSE);
+ .addListener(ChannelFutureListener.CLOSE);
Review Comment:
but the current style check specify that the code indented in multiples of 4，so we need to decide which style to use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] javeme commented on a diff in pull request #1845: fix hugegraph-api code checkstyle
Posted by GitBox <gi...@apache.org>.
javeme commented on code in PR #1845:
URL: https://github.com/apache/incubator-hugegraph/pull/1845#discussion_r857601135
##########
hugegraph-api/src/main/java/com/baidu/hugegraph/auth/HugeFactoryAuthProxy.java:
##########
@@ -60,17 +61,20 @@
import com.baidu.hugegraph.variables.HugeVariables;
import com.google.common.collect.ImmutableSet;
+import org.slf4j.Logger;
import sun.reflect.Reflection;
public final class HugeFactoryAuthProxy {
+ private static final Logger LOG = Log.logger(HugeFactoryAuthProxy.class);
+
public static final String GRAPH_FACTORY =
- "gremlin.graph=com.baidu.hugegraph.auth.HugeFactoryAuthProxy";
+ "gremlin.graph=com.baidu.hugegraph.auth.HugeFactoryAuthProxy";
private static final Set<String> PROTECT_METHODS = ImmutableSet.of(
- "instance");
+ "instance");
Review Comment:
align with ImmutableSet
##########
hugegraph-api/src/main/java/com/baidu/hugegraph/api/graph/BatchAPI.java:
##########
@@ -47,11 +47,11 @@ public class BatchAPI extends API {
private static final Logger LOG = Log.logger(BatchAPI.class);
// NOTE: VertexAPI and EdgeAPI should share a counter
- private static final AtomicInteger batchWriteThreads = new AtomicInteger(0);
+ private static final AtomicInteger BATCH_WRITE_THREADS = new AtomicInteger(0);
static {
MetricsUtil.registerGauge(RestServer.class, "batch-write-threads",
- () -> batchWriteThreads.intValue());
+ BATCH_WRITE_THREADS::intValue);
Review Comment:
align with RestServer
##########
hugegraph-api/src/main/java/com/baidu/hugegraph/auth/StandardAuthenticator.java:
##########
@@ -95,7 +99,7 @@ private String inputPassword() {
if (!password.isEmpty()) {
return password;
}
- System.out.println(notEmptyPrompt);
+ LOG.info(notEmptyPrompt);
Review Comment:
yes we need System.out sometimes like when using the console
##########
hugegraph-api/src/main/java/com/baidu/hugegraph/auth/HugeAuthenticator.java:
##########
@@ -254,7 +248,7 @@ public static class UserJson {
}
}
- public static class RolePerm {
+ class RolePerm {
Review Comment:
prefer to keep `public static class`
##########
hugegraph-api/src/main/java/com/baidu/hugegraph/auth/HugeGraphAuthProxy.java:
##########
@@ -210,16 +210,12 @@ public Collection<PropertyKey> propertyKeys() {
@Override
public PropertyKey propertyKey(String key) {
- return verifySchemaPermission(HugePermission.READ, () -> {
- return this.hugegraph.propertyKey(key);
- });
+ return verifySchemaPermission(HugePermission.READ, () -> this.hugegraph.propertyKey(key));
Review Comment:
prefer to keep origin style for debug and readability
##########
hugegraph-api/src/main/java/com/baidu/hugegraph/auth/HugeAuthenticator.java:
##########
@@ -394,7 +388,7 @@ public static boolean match(Object role, RolePermission grant,
}
}
- public static class RequiredPerm {
+ class RequiredPerm {
Review Comment:
prefer to keep `public static class`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] imbajin commented on pull request #1845: fix hugegraph-api code checkstyle
Posted by GitBox <gi...@apache.org>.
imbajin commented on PR #1845:
URL: https://github.com/apache/incubator-hugegraph/pull/1845#issuecomment-1108066040
Open a new vote discussion in [#1848](https://github.com/apache/incubator-hugegraph/discussions/1848)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph] Fizell closed pull request #1845: fix hugegraph-api code checkstyle
Posted by GitBox <gi...@apache.org>.
Fizell closed pull request #1845: fix hugegraph-api code checkstyle
URL: https://github.com/apache/incubator-hugegraph/pull/1845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org