You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Quinn Leng <qu...@gmail.com> on 2017/08/03 17:57:49 UTC
Review Request 61408: Added test cases for V1 teardown Call.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61408/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar and Greg Mann.
Bugs: MESOS-6846
https://issues.apache.org/jira/browse/MESOS-6846
Repository: mesos
Description
-------
Added test cases for teardown operation in V1 operator API.
Diffs
-----
src/tests/api_tests.cpp 1d5b080c809248bdf4c76ddad382d714692c804b
Diff: https://reviews.apache.org/r/61408/diff/1/
Testing
-------
make check
Thanks,
Quinn Leng
Re: Review Request 61408: Added test cases for V1 teardown Call.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61408/#review183180
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61222, 61408]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On Aug. 17, 2017, 5:33 p.m., Quinn Leng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61408/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2017, 5:33 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Greg Mann.
>
>
> Bugs: MESOS-6846
> https://issues.apache.org/jira/browse/MESOS-6846
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test cases for teardown operation in V1 operator API.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp 75f7a585ec75f1d8b78453dd203bb78822ee7bc9
>
>
> Diff: https://reviews.apache.org/r/61408/diff/4/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Quinn Leng
>
>
Re: Review Request 61408: Added test cases for V1 teardown Call.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61408/#review183178
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61222, 61408]
Logs available here: http://104.210.40.105/logs/master/61408
- Mesos Reviewbot Windows
On Aug. 17, 2017, 2:33 p.m., Quinn Leng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61408/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2017, 2:33 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Greg Mann.
>
>
> Bugs: MESOS-6846
> https://issues.apache.org/jira/browse/MESOS-6846
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test cases for teardown operation in V1 operator API.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp 75f7a585ec75f1d8b78453dd203bb78822ee7bc9
>
>
> Diff: https://reviews.apache.org/r/61408/diff/4/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Quinn Leng
>
>
Re: Review Request 61408: Added test cases for V1 teardown Call.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61408/#review183271
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On Aug. 17, 2017, 9:33 p.m., Quinn Leng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61408/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2017, 9:33 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Greg Mann.
>
>
> Bugs: MESOS-6846
> https://issues.apache.org/jira/browse/MESOS-6846
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test cases for teardown operation in V1 operator API.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp 75f7a585ec75f1d8b78453dd203bb78822ee7bc9
>
>
> Diff: https://reviews.apache.org/r/61408/diff/4/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Quinn Leng
>
>
Re: Review Request 61408: Added test cases for V1 teardown Call.
Posted by Quinn Leng <qu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61408/
-----------------------------------------------------------
(Updated Aug. 17, 2017, 9:33 p.m.)
Review request for mesos, Anand Mazumdar and Greg Mann.
Bugs: MESOS-6846
https://issues.apache.org/jira/browse/MESOS-6846
Repository: mesos
Description
-------
Added test cases for teardown operation in V1 operator API.
Diffs (updated)
-----
src/tests/api_tests.cpp 75f7a585ec75f1d8b78453dd203bb78822ee7bc9
Diff: https://reviews.apache.org/r/61408/diff/4/
Changes: https://reviews.apache.org/r/61408/diff/3-4/
Testing
-------
make check
Thanks,
Quinn Leng
Re: Review Request 61408: Added test cases for V1 teardown Call.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61408/#review182923
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61222, 61408]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On Aug. 15, 2017, 12:07 a.m., Quinn Leng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61408/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2017, 12:07 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Greg Mann.
>
>
> Bugs: MESOS-6846
> https://issues.apache.org/jira/browse/MESOS-6846
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test cases for teardown operation in V1 operator API.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp 75f7a585ec75f1d8b78453dd203bb78822ee7bc9
>
>
> Diff: https://reviews.apache.org/r/61408/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Quinn Leng
>
>
Re: Review Request 61408: Added test cases for V1 teardown Call.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61408/#review182954
-----------------------------------------------------------
src/tests/api_tests.cpp
Lines 2903-2904 (original), 2903-2905 (patched)
<https://reviews.apache.org/r/61408/#comment258921>
Need one more newline here.
src/tests/api_tests.cpp
Lines 2987 (patched)
<https://reviews.apache.org/r/61408/#comment258924>
s/of 'GET_FRAMEWORKS'/to the 'GET_FRAMEWORKS'/
src/tests/api_tests.cpp
Lines 2992 (patched)
<https://reviews.apache.org/r/61408/#comment258923>
Since you do this at the beginning of the test, you don't need to do it here or anywhere below.
src/tests/api_tests.cpp
Lines 3019-3023 (patched)
<https://reviews.apache.org/r/61408/#comment258922>
Not indented far enough, here and below.
src/tests/api_tests.cpp
Lines 3052-3053 (patched)
<https://reviews.apache.org/r/61408/#comment258925>
Could you add a comment here saying that the successful teardown call is being submitted? I think it would improve readability a little.
- Greg Mann
On Aug. 15, 2017, 12:07 a.m., Quinn Leng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61408/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2017, 12:07 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Greg Mann.
>
>
> Bugs: MESOS-6846
> https://issues.apache.org/jira/browse/MESOS-6846
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test cases for teardown operation in V1 operator API.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp 75f7a585ec75f1d8b78453dd203bb78822ee7bc9
>
>
> Diff: https://reviews.apache.org/r/61408/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Quinn Leng
>
>
Re: Review Request 61408: Added test cases for V1 teardown Call.
Posted by Quinn Leng <qu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61408/
-----------------------------------------------------------
(Updated Aug. 15, 2017, 12:07 a.m.)
Review request for mesos, Anand Mazumdar and Greg Mann.
Bugs: MESOS-6846
https://issues.apache.org/jira/browse/MESOS-6846
Repository: mesos
Description
-------
Added test cases for teardown operation in V1 operator API.
Diffs (updated)
-----
src/tests/api_tests.cpp 75f7a585ec75f1d8b78453dd203bb78822ee7bc9
Diff: https://reviews.apache.org/r/61408/diff/3/
Changes: https://reviews.apache.org/r/61408/diff/2-3/
Testing
-------
make check
Thanks,
Quinn Leng
Re: Review Request 61408: Added test cases for V1 teardown Call.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61408/#review182655
-----------------------------------------------------------
src/tests/api_tests.cpp
Lines 2905-2906 (patched)
<https://reviews.apache.org/r/61408/#comment258631>
How about:
"This test verifies that when the operator API TEARDOWN call is made, the framework is shutdown and removed. It also confirms that authorization of this call is performed correctly."
src/tests/api_tests.cpp
Lines 2911-2931 (patched)
<https://reviews.apache.org/r/61408/#comment258633>
If you set the `permissive` bit to `true`, then I think we can get rid of these first 3 ACLs, which would improve readability a little. Then you could explicitly set an ACL for DEFAULT_CREDENTIAL_2.
src/tests/api_tests.cpp
Lines 2949-2953 (patched)
<https://reviews.apache.org/r/61408/#comment258635>
Since the containerizer is created to be injected into the agent, let's have these two blocks switch places:
```
Future<RegisterSlaveMessage> registerSlaveMessage =
FUTURE_PROTOBUF(RegisterSlaveMessage(), _, _);
ExecutorID executorId = DEFAULT_EXECUTOR_ID;
TestContainerizer containerizer(executorId, executor);
```
src/tests/api_tests.cpp
Lines 2964 (patched)
<https://reviews.apache.org/r/61408/#comment258636>
Is this necessary?
src/tests/api_tests.cpp
Lines 3024-3025 (patched)
<https://reviews.apache.org/r/61408/#comment258688>
Fits on one line.
src/tests/api_tests.cpp
Lines 3070-3071 (patched)
<https://reviews.apache.org/r/61408/#comment258689>
Fits on one line.
- Greg Mann
On Aug. 10, 2017, 10:47 p.m., Quinn Leng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61408/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2017, 10:47 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Greg Mann.
>
>
> Bugs: MESOS-6846
> https://issues.apache.org/jira/browse/MESOS-6846
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test cases for teardown operation in V1 operator API.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp 75f7a585ec75f1d8b78453dd203bb78822ee7bc9
>
>
> Diff: https://reviews.apache.org/r/61408/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Quinn Leng
>
>
Re: Review Request 61408: Added test cases for V1 teardown Call.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61408/#review182678
-----------------------------------------------------------
Bad patch!
Reviews applied: [61222, 61408]
Logs available here: http://104.210.40.105/logs/master/61408
- Mesos Reviewbot Windows
On Aug. 10, 2017, 10:47 p.m., Quinn Leng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61408/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2017, 10:47 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Greg Mann.
>
>
> Bugs: MESOS-6846
> https://issues.apache.org/jira/browse/MESOS-6846
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test cases for teardown operation in V1 operator API.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp 75f7a585ec75f1d8b78453dd203bb78822ee7bc9
>
>
> Diff: https://reviews.apache.org/r/61408/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Quinn Leng
>
>
Re: Review Request 61408: Added test cases for V1 teardown Call.
Posted by Quinn Leng <qu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61408/
-----------------------------------------------------------
(Updated Aug. 10, 2017, 10:47 p.m.)
Review request for mesos, Anand Mazumdar and Greg Mann.
Bugs: MESOS-6846
https://issues.apache.org/jira/browse/MESOS-6846
Repository: mesos
Description
-------
Added test cases for teardown operation in V1 operator API.
Diffs (updated)
-----
src/tests/api_tests.cpp 75f7a585ec75f1d8b78453dd203bb78822ee7bc9
Diff: https://reviews.apache.org/r/61408/diff/2/
Changes: https://reviews.apache.org/r/61408/diff/1-2/
Testing
-------
make check
Thanks,
Quinn Leng
Re: Review Request 61408: Added test cases for V1 teardown Call.
Posted by Quinn Leng <qu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61408/#review182630
-----------------------------------------------------------
src/tests/api_tests.cpp
Lines 2739-2758 (patched)
<https://reviews.apache.org/r/61408/#comment258608>
check in the unversioned teardown call test case, if it doesn't contain authorization test, add it here.
- Quinn Leng
On Aug. 3, 2017, 5:57 p.m., Quinn Leng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61408/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2017, 5:57 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Greg Mann.
>
>
> Bugs: MESOS-6846
> https://issues.apache.org/jira/browse/MESOS-6846
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test cases for teardown operation in V1 operator API.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp 1d5b080c809248bdf4c76ddad382d714692c804b
>
>
> Diff: https://reviews.apache.org/r/61408/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Quinn Leng
>
>