[GitHub] [hudi] vinothchandar commented on a change in pull request #3491: [HUDI-2315] Restore 0.8.0 config keys with deprecated annotation

[GitBox <gi...@apache.org>]

vinothchandar commented on a change in pull request #3491:
URL: https://github.com/apache/hudi/pull/3491#discussion_r690876029



##########
File path: hudi-spark-datasource/hudi-spark2/src/main/java/org/apache/hudi/internal/DefaultSource.java
##########
@@ -61,11 +61,11 @@ public DataSourceReader createReader(DataSourceOptions options) {
       DataSourceOptions options) {
     String instantTime = options.get(DataSourceInternalWriterHelper.INSTANT_TIME_OPT_KEY).get();
     String path = options.get("path").get();
-    String tblName = options.get(HoodieWriteConfig.TABLE_NAME.key()).get();
+    String tblName = options.get(HoodieWriteConfig.TABLE_NAME_VALUE.key()).get();

Review comment:
       I'd like to avoid suffixes like _CFG or _CONF, given everything else here is a config as well and the class is named xxxConfig. 
   
   I get your point though. Not a lot of great choices here. _TBL_NAME_ or just _TABLE_? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org