You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jason Zhou <ja...@gmail.com> on 2024/08/06 16:29:26 UTC

Review Request 75142: [device manager] add device info file path helper

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75142/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
-------

Currently we do not have a place to keep the checkpoint file for the
device manager.

This patch adds a path helper that gives us a file that lets  us
checkpoint the device manager state.


Diffs
-----

  src/slave/paths.hpp 7d43e9c0170c7bcced916a892590063005133d6f 
  src/slave/paths.cpp 3e44b636c76c01f88b00f5f8d2db39cc5fe00c1c 


Diff: https://reviews.apache.org/r/75142/diff/1/


Testing
-------

In later patches of the stack, this helper was able to let us write and recover from the file containing checkpointed state.


Thanks,

Jason Zhou


Re: Review Request 75142: [device manager] add device info file path helper

Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75142/#review226776
-----------------------------------------------------------




src/slave/paths.cpp
Lines 75 (patched)
<https://reviews.apache.org/r/75142/#comment315072>

    looking at the other files here.. isn't this more like a .state file?
    
    .info files seem to be about static information like TaskInfo, ExecutorInfo, FrameworkInfo, whereas states seem to be about checkpointing mutable state of a component, which is what we're doing here? This also lines up with your file names (state.proto / state.hpp), also be sure to name the protobuf message consistently with the other .state files (I already landed it :))


- Benjamin Mahler


On Aug. 6, 2024, 4:29 p.m., Jason Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75142/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2024, 4:29 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Currently we do not have a place to keep the checkpoint file for the
> device manager.
> 
> This patch adds a path helper that gives us a file that lets  us
> checkpoint the device manager state.
> 
> 
> Diffs
> -----
> 
>   src/slave/paths.hpp 7d43e9c0170c7bcced916a892590063005133d6f 
>   src/slave/paths.cpp 3e44b636c76c01f88b00f5f8d2db39cc5fe00c1c 
> 
> 
> Diff: https://reviews.apache.org/r/75142/diff/2/
> 
> 
> Testing
> -------
> 
> In later patches of the stack, this helper was able to let us write and recover from the file containing checkpointed state.
> 
> 
> Thanks,
> 
> Jason Zhou
> 
>


Re: Review Request 75142: [device manager] add device state file path helper

Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75142/#review226784
-----------------------------------------------------------


Ship it!





src/slave/paths.cpp
Lines 814 (patched)
<https://reviews.apache.org/r/75142/#comment315088>

    nit: brace on next line


- Benjamin Mahler


On Aug. 7, 2024, 4:46 p.m., Jason Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75142/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2024, 4:46 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Currently we do not have a place to keep the checkpoint file for the
> device manager.
> 
> This patch adds a path helper that gives us a file that lets  us
> checkpoint the device manager state.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/device_manager/state.proto 5b7ab36c3fa849f57e225401ad3500aa343a3969 
>   src/slave/paths.hpp 7d43e9c0170c7bcced916a892590063005133d6f 
>   src/slave/paths.cpp 3e44b636c76c01f88b00f5f8d2db39cc5fe00c1c 
> 
> 
> Diff: https://reviews.apache.org/r/75142/diff/4/
> 
> 
> Testing
> -------
> 
> In later patches of the stack, this helper was able to let us write and recover from the file containing checkpointed state.
> 
> 
> Thanks,
> 
> Jason Zhou
> 
>


Re: Review Request 75142: [device manager] add device state file path helper

Posted by Jason Zhou <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75142/
-----------------------------------------------------------

(Updated Aug. 7, 2024, 4:46 p.m.)


Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
-------

Currently we do not have a place to keep the checkpoint file for the
device manager.

This patch adds a path helper that gives us a file that lets  us
checkpoint the device manager state.


Diffs (updated)
-----

  src/slave/containerizer/device_manager/state.proto 5b7ab36c3fa849f57e225401ad3500aa343a3969 
  src/slave/paths.hpp 7d43e9c0170c7bcced916a892590063005133d6f 
  src/slave/paths.cpp 3e44b636c76c01f88b00f5f8d2db39cc5fe00c1c 


Diff: https://reviews.apache.org/r/75142/diff/4/

Changes: https://reviews.apache.org/r/75142/diff/3-4/


Testing
-------

In later patches of the stack, this helper was able to let us write and recover from the file containing checkpointed state.


Thanks,

Jason Zhou


Re: Review Request 75142: [device manager] add device state file path helper

Posted by Jason Zhou <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75142/
-----------------------------------------------------------

(Updated Aug. 7, 2024, 3:35 p.m.)


Review request for mesos and Benjamin Mahler.


Summary (updated)
-----------------

[device manager] add device state file path helper


Repository: mesos


Description
-------

Currently we do not have a place to keep the checkpoint file for the
device manager.

This patch adds a path helper that gives us a file that lets  us
checkpoint the device manager state.


Diffs (updated)
-----

  src/slave/containerizer/device_manager/state.proto 5b7ab36c3fa849f57e225401ad3500aa343a3969 
  src/slave/paths.hpp 7d43e9c0170c7bcced916a892590063005133d6f 
  src/slave/paths.cpp 3e44b636c76c01f88b00f5f8d2db39cc5fe00c1c 


Diff: https://reviews.apache.org/r/75142/diff/3/

Changes: https://reviews.apache.org/r/75142/diff/2-3/


Testing
-------

In later patches of the stack, this helper was able to let us write and recover from the file containing checkpointed state.


Thanks,

Jason Zhou