You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/02 22:20:46 UTC

[GitHub] [airflow] turbaszek commented on a change in pull request #12763: Avoid log spam & have more meaningful log when pull image in DockerOperator

turbaszek commented on a change in pull request #12763:
URL: https://github.com/apache/airflow/pull/12763#discussion_r534520589



##########
File path: airflow/providers/docker/operators/docker.py
##########
@@ -282,13 +282,20 @@ def execute(self, context) -> Optional[str]:
             raise Exception("The 'cli' should be initialized before!")
 
         # Pull the docker image if `force_pull` is set or image does not exist locally
+        # pylint: disable=too-many-nested-blocks
         if self.force_pull or not self.cli.images(name=self.image):
             self.log.info('Pulling docker image %s', self.image)
+            latest_status = {}
             for output in self.cli.pull(self.image, stream=True, decode=True):
                 if isinstance(output, str):
                     self.log.info("%s", output)

Review comment:
       ```suggestion
                       self.log.info("%s", output)
                       continue
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org