You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by Jihoon Son <ji...@apache.org> on 2014/06/02 16:10:22 UTC

Re: Review Request 21909: TAJO-849: Add Parquet storage to HCatalogStore.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21909/#review44495
-----------------------------------------------------------

Ship it!


+1
This patch looks good to me.

- Jihoon Son


On May 26, 2014, 9:37 p.m., Jung JaeHwa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21909/
> -----------------------------------------------------------
> 
> (Updated May 26, 2014, 9:37 p.m.)
> 
> 
> Review request for Tajo.
> 
> 
> Bugs: TAJO-849
>     https://issues.apache.org/jira/browse/TAJO-849
> 
> 
> Repository: tajo
> 
> 
> Description
> -------
> 
> Currently, tajo supports Parquet storage. But users just can use this storage with DerbyStore and MySQLStore. Thus, we need to add it to HCatalogStore.
> 
> 
> Diffs
> -----
> 
>   tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/pom.xml a3cb99b 
>   tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java 7924af1 
>   tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogUtil.java 98aa7c5 
>   tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/test/java/org/apache/tajo/catalog/store/TestHCatalogStore.java 729184a 
>   tajo-dist/pom.xml c826c57 
> 
> Diff: https://reviews.apache.org/r/21909/diff/
> 
> 
> Testing
> -------
> 
> mvn clean install -Phcatalog-0.12.0
> 
> 
> Thanks,
> 
> Jung JaeHwa
> 
>


Re: Review Request 21909: TAJO-849: Add Parquet storage to HCatalogStore.

Posted by Jung JaeHwa <bl...@apache.org>.

> On June 2, 2014, 2:10 p.m., Jihoon Son wrote:
> > +1
> > This patch looks good to me.

Jihoon, thank you for your review. :)


- Jung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21909/#review44495
-----------------------------------------------------------


On May 26, 2014, 12:37 p.m., Jung JaeHwa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21909/
> -----------------------------------------------------------
> 
> (Updated May 26, 2014, 12:37 p.m.)
> 
> 
> Review request for Tajo.
> 
> 
> Bugs: TAJO-849
>     https://issues.apache.org/jira/browse/TAJO-849
> 
> 
> Repository: tajo
> 
> 
> Description
> -------
> 
> Currently, tajo supports Parquet storage. But users just can use this storage with DerbyStore and MySQLStore. Thus, we need to add it to HCatalogStore.
> 
> 
> Diffs
> -----
> 
>   tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/pom.xml a3cb99b 
>   tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java 7924af1 
>   tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogUtil.java 98aa7c5 
>   tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/test/java/org/apache/tajo/catalog/store/TestHCatalogStore.java 729184a 
>   tajo-dist/pom.xml c826c57 
> 
> Diff: https://reviews.apache.org/r/21909/diff/
> 
> 
> Testing
> -------
> 
> mvn clean install -Phcatalog-0.12.0
> 
> 
> Thanks,
> 
> Jung JaeHwa
> 
>