You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/02/19 03:34:15 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #301:
arch/sim: Unify the driver initialization function name
xiaoxiang781216 opened a new pull request #301: arch/sim: Unify the driver initialization function name
URL: https://github.com/apache/incubator-nuttx/pull/301
change the sim_ prefix to the up_ prefix
Change-Id: I78417cbd2d4d68dddaf99c8ecba60ef3197eec5d
Signed-off-by: Xiang Xiao <xi...@xiaomi.com>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 closed pull request #301:
arch/sim: Unify the driver initialization function name
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 closed pull request #301: arch/sim: Unify the driver initialization function name
URL: https://github.com/apache/incubator-nuttx/pull/301
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #301: arch/sim:
Unify the driver initialization function name
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #301: arch/sim: Unify the driver initialization function name
URL: https://github.com/apache/incubator-nuttx/pull/301#issuecomment-588222487
I think we should close this without merging. What is your opinion. Do you disagree with the naming convention?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #301: arch/sim:
Unify the driver initialization function name
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #301: arch/sim: Unify the driver initialization function name
URL: https://github.com/apache/incubator-nuttx/pull/301#issuecomment-588226572
All of the up_ file names are also wrong. These should all be sim_ . The "microcontroller" name should always be used as the file name prefix. The microntroller name should be the prefix used on all internal functions (including the board/ directories).
The correct change would be to change all of the up_ names to sim_.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #301:
arch/sim: Unify the driver initialization function name
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #301: arch/sim: Unify the driver initialization function name
URL: https://github.com/apache/incubator-nuttx/pull/301#issuecomment-588230957
> I think we should close this without merging. What is your opinion. Do you disagree with the naming convention?
Ok, it's fine to change all private up_ to sim_, the consistent is most important thingfor me. I will find sometime to update the PR, let's close it now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #301: arch/sim:
Unify the driver initialization function name
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #301: arch/sim: Unify the driver initialization function name
URL: https://github.com/apache/incubator-nuttx/pull/301#issuecomment-588221906
sim_ is actually the correct prefix. See https://cwiki.apache.org/confluence/display/NUTTX/Naming+FAQ
up_ should ONLY be used with common microcontroller interfaces. So all internal sim interfaces must begin with sim_ not up_. Only common interfaces accessed outside of sim/ should begin with up_
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #301: arch/sim:
Unify the driver initialization function name
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #301: arch/sim: Unify the driver initialization function name
URL: https://github.com/apache/incubator-nuttx/pull/301#issuecomment-588241011
Yes, there is a big problem with consistency. I tend to try to define a rule, then slowly bring things into agreement with the rule. I am too careful and avoid too much turmoil. A good is example is: arch/arm/src/armv7-m which has incorrect naming and arch/arm/src/armv7-a which has correct naming. I planned to change arch/arm/src/armv7-m to follow the convention too someday.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services