You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by "Jagadish (JIRA)" <ji...@apache.org> on 2016/03/17 08:57:33 UTC

[jira] [Created] (SAMZA-900) Re think the ContainerAllocator, AbstractContainerAllocator, HostAwareContainerAllocator hierarchy

Jagadish created SAMZA-900:
------------------------------

             Summary: Re think the ContainerAllocator, AbstractContainerAllocator, HostAwareContainerAllocator hierarchy
                 Key: SAMZA-900
                 URL: https://issues.apache.org/jira/browse/SAMZA-900
             Project: Samza
          Issue Type: Bug
            Reporter: Jagadish


[~cpettitt-linkedin] in his feedback pointed out:

"I think we could simplify some of the interactions across classes if we make this a concrete task that takes a container allocator strategy interface (e.g. standard or host aware). A few nice properties that fall out:

The allocators don't need to know the inner workings of AbstractContainerAllocator (ACA). In fact, the implementation of ACA can change without breaking allocators.

It easy to test just the allocator strategy in isolation because it becomes more functional in nature (e.g. no direct dependency on state in ACA).
Easier to code review due to less cross-class interactions ;)"

I'm in agreement that the current design should improve. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)