You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "Petahhh (GitHub)" <gi...@apache.org> on 2019/01/15 18:58:07 UTC
[GitHub] [geode] Petahhh opened pull request #3078: GEODE-6274:
Removes CreateRegionCommand build warning
Signed-off-by: Peter Tran <pt...@pivotal.io>
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/3078 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] aditya87 commented on pull request #3078:
GEODE-6274: Removes CreateRegionCommand build warning
Posted by "aditya87 (GitHub)" <gi...@apache.org>.
Feel like that would be a pretty big change? I didn't realize we were moving off of CliStrings...
[ Full content available at: https://github.com/apache/geode/pull/3078 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao closed pull request #3078: GEODE-6274:
Removes CreateRegionCommand build warning
Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
[ pull request closed by jinmeiliao ]
[ Full content available at: https://github.com/apache/geode/pull/3078 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao commented on pull request #3078:
GEODE-6274: Removes CreateRegionCommand build warning
Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
I would always use String.format instead our home baked CliStrings.format
[ Full content available at: https://github.com/apache/geode/pull/3078 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao commented on pull request #3078:
GEODE-6274: Removes CreateRegionCommand build warning
Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
looks like you have a failing test with this. It's much simpler to use String.format in this case.
[ Full content available at: https://github.com/apache/geode/pull/3078 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] Petahhh commented on pull request #3078: GEODE-6274:
Removes CreateRegionCommand build warning
Posted by "Petahhh (GitHub)" <gi...@apache.org>.
Thanks!
[ Full content available at: https://github.com/apache/geode/pull/3078 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] Petahhh commented on issue #3078: GEODE-6274:
Removes CreateRegionCommand build warning
Posted by "Petahhh (GitHub)" <gi...@apache.org>.
Please comment @jdeppe-pivotal @pdxrunner @jinmeiliao when you can. Thank you!
[ Full content available at: https://github.com/apache/geode/pull/3078 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org