You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/02/21 12:39:59 UTC

[GitHub] [pinot] richardstartin commented on pull request #8237: Do not perform another pass of Query Automaton Minimization

richardstartin commented on pull request #8237:
URL: https://github.com/apache/pinot/pull/8237#issuecomment-1046835075


   I got these numbers with JDK11 (coretto) on my MacBook Pro with the CLI args below:
   
   ```
   java -jar pinot-perf/target/benchmarks.jar -wi 5 -i 5 -r 1 -w 2 -f 1 -bm avgt -jvmArgsPrepend "-ms4G -mx4G -XX:+AlwaysPreTouch -XX:+UseParallelGC" BenchmarkNativeAndLuceneBasedLike
   ```
   
   ```
   Benchmark                                (_fstType)  (_intBaseValue)  (_numBlocks)  (_numRows)                                                                    (_query)  Mode  Cnt    Score   Error  Units
   BenchmarkNativeAndLuceneBasedLike.query      LUCENE             1000             0     2500000     SELECT INT_COL, URL_COL FROM MyTable WHERE DOMAIN_NAMES LIKE '%domain%'  avgt    5   47.434 ± 0.878  us/op
   BenchmarkNativeAndLuceneBasedLike.query      LUCENE             1000             0     2500000  SELECT INT_COL, URL_COL FROM MyTable WHERE DOMAIN_NAMES LIKE 'www.domain%'  avgt    5   49.754 ± 1.126  us/op
   BenchmarkNativeAndLuceneBasedLike.query      LUCENE             1000             1     2500000     SELECT INT_COL, URL_COL FROM MyTable WHERE DOMAIN_NAMES LIKE '%domain%'  avgt    5   51.999 ± 0.557  us/op
   BenchmarkNativeAndLuceneBasedLike.query      LUCENE             1000             1     2500000  SELECT INT_COL, URL_COL FROM MyTable WHERE DOMAIN_NAMES LIKE 'www.domain%'  avgt    5   53.120 ± 0.825  us/op
   BenchmarkNativeAndLuceneBasedLike.query      LUCENE             1000            10     2500000     SELECT INT_COL, URL_COL FROM MyTable WHERE DOMAIN_NAMES LIKE '%domain%'  avgt    5   59.283 ± 1.135  us/op
   BenchmarkNativeAndLuceneBasedLike.query      LUCENE             1000            10     2500000  SELECT INT_COL, URL_COL FROM MyTable WHERE DOMAIN_NAMES LIKE 'www.domain%'  avgt    5   62.024 ± 1.437  us/op
   BenchmarkNativeAndLuceneBasedLike.query      LUCENE             1000           100     2500000     SELECT INT_COL, URL_COL FROM MyTable WHERE DOMAIN_NAMES LIKE '%domain%'  avgt    5  117.280 ± 0.580  us/op
   BenchmarkNativeAndLuceneBasedLike.query      LUCENE             1000           100     2500000  SELECT INT_COL, URL_COL FROM MyTable WHERE DOMAIN_NAMES LIKE 'www.domain%'  avgt    5  164.621 ± 8.522  us/op
   BenchmarkNativeAndLuceneBasedLike.query      NATIVE             1000             0     2500000     SELECT INT_COL, URL_COL FROM MyTable WHERE DOMAIN_NAMES LIKE '%domain%'  avgt    5   44.811 ± 1.573  us/op
   BenchmarkNativeAndLuceneBasedLike.query      NATIVE             1000             0     2500000  SELECT INT_COL, URL_COL FROM MyTable WHERE DOMAIN_NAMES LIKE 'www.domain%'  avgt    5   14.112 ± 0.155  us/op
   BenchmarkNativeAndLuceneBasedLike.query      NATIVE             1000             1     2500000     SELECT INT_COL, URL_COL FROM MyTable WHERE DOMAIN_NAMES LIKE '%domain%'  avgt    5   49.487 ± 0.414  us/op
   BenchmarkNativeAndLuceneBasedLike.query      NATIVE             1000             1     2500000  SELECT INT_COL, URL_COL FROM MyTable WHERE DOMAIN_NAMES LIKE 'www.domain%'  avgt    5   19.014 ± 0.583  us/op
   BenchmarkNativeAndLuceneBasedLike.query      NATIVE             1000            10     2500000     SELECT INT_COL, URL_COL FROM MyTable WHERE DOMAIN_NAMES LIKE '%domain%'  avgt    5   54.869 ± 0.861  us/op
   BenchmarkNativeAndLuceneBasedLike.query      NATIVE             1000            10     2500000  SELECT INT_COL, URL_COL FROM MyTable WHERE DOMAIN_NAMES LIKE 'www.domain%'  avgt    5   29.343 ± 0.206  us/op
   BenchmarkNativeAndLuceneBasedLike.query      NATIVE             1000           100     2500000     SELECT INT_COL, URL_COL FROM MyTable WHERE DOMAIN_NAMES LIKE '%domain%'  avgt    5  115.629 ± 5.838  us/op
   BenchmarkNativeAndLuceneBasedLike.query      NATIVE             1000           100     2500000  SELECT INT_COL, URL_COL FROM MyTable WHERE DOMAIN_NAMES LIKE 'www.domain%'  avgt    5  128.661 ± 3.260  us/op
   ```
   
   So no integer multiple differences in this run, but the native implementation appears to warm up faster. I can run this on some more stable machines, but we wouldn't see this kind of improvement by accident.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org