You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/02/10 14:01:58 UTC

[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1811: TPC-DS benchmark expose cli arg breakdown

pan3793 commented on a change in pull request #1811:
URL: https://github.com/apache/incubator-kyuubi/pull/1811#discussion_r803704487



##########
File path: dev/kyuubi-tpcds/src/main/scala/org/apache/kyuubi/tpcds/benchmark/RunBenchmark.scala
##########
@@ -75,8 +78,6 @@ object RunBenchmark {
     val sparkSession = SparkSession.builder.config(conf).enableHiveSupport().getOrCreate()
     import sparkSession.implicits._
 
-    sparkSession.conf.set("spark.sql.perf.results", new File("performance").toURI.toString)

Review comment:
       Hardcode `file://` protocol does not make sense, especially for user who run benchmark on clusters, we can set the default path without protocol.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org