You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2023/01/12 18:36:47 UTC
[GitHub] [maven-integration-testing] slawekjaranowski opened a new pull request, #231: Fix MavenITmng5669ReadPomsOnce
slawekjaranowski opened a new pull request, #231:
URL: https://github.com/apache/maven-integration-testing/pull/231
In test, we check if pom files are read only once.
When we update plugin or dependencies in test,
number of read items can change again.
So should be good enough to check if duplicate items exist in log file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] slawekjaranowski commented on a diff in pull request #231: Fix MavenITmng5669ReadPomsOnce
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #231:
URL: https://github.com/apache/maven-integration-testing/pull/231#discussion_r1068701908
##########
core-it-suite/src/test/resources-filtered/bootstrap.txt:
##########
@@ -79,13 +79,15 @@ org.apache.maven.plugins:maven-dependency-plugin:3.3.0
org.apache.maven.plugins:maven-deploy-plugin:${stubPluginVersion}
org.apache.maven.plugins:maven-deploy-plugin:2.7
org.apache.maven.plugins:maven-deploy-plugin:3.0.0
+org.apache.maven.plugins:maven-deploy-plugin:3.0.0-M2
Review Comment:
rebased
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] cstamas commented on a diff in pull request #231: Fix MavenITmng5669ReadPomsOnce
Posted by GitBox <gi...@apache.org>.
cstamas commented on code in PR #231:
URL: https://github.com/apache/maven-integration-testing/pull/231#discussion_r1068637910
##########
core-it-suite/src/test/resources-filtered/bootstrap.txt:
##########
@@ -79,13 +79,15 @@ org.apache.maven.plugins:maven-dependency-plugin:3.3.0
org.apache.maven.plugins:maven-deploy-plugin:${stubPluginVersion}
org.apache.maven.plugins:maven-deploy-plugin:2.7
org.apache.maven.plugins:maven-deploy-plugin:3.0.0
+org.apache.maven.plugins:maven-deploy-plugin:3.0.0-M2
Review Comment:
these will not be needed once https://github.com/apache/maven-integration-testing/pull/230 merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] slawekjaranowski merged pull request #231: Fix MavenITmng5669ReadPomsOnce
Posted by GitBox <gi...@apache.org>.
slawekjaranowski merged PR #231:
URL: https://github.com/apache/maven-integration-testing/pull/231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org