You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2015/08/19 09:28:29 UTC
Review Request 37601: RANGER-610: Update Audit page to add 'Tags'
column
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37601/
-----------------------------------------------------------
Review request for ranger, Gautam Borad, Abhay Kulkarni, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-610
https://issues.apache.org/jira/browse/RANGER-610
Repository: ranger
Description
-------
Audit page updated with addition of 'Tags' column. (submitting the review on behalf of Gautam Borad)
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java 154d1c3
security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 897ed5d
security-admin/src/main/java/org/apache/ranger/entity/XXAccessAudit.java 6e35fa4
security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java e5de160
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyServiceBase.java 9584c3d
security-admin/src/main/java/org/apache/ranger/service/XAccessAuditService.java 98c987e
security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 5fc45d2
security-admin/src/main/java/org/apache/ranger/view/VXAccessAudit.java bcffd4d
security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js b3147ee
Diff: https://reviews.apache.org/r/37601/diff/
Testing
-------
Thanks,
Madhan Neethiraj
Re: Review Request 37601: RANGER-610: Update Audit page to add 'Tags'
column
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37601/#review95839
-----------------------------------------------------------
Ship it!
security-admin/src/main/java/org/apache/ranger/entity/XXAccessAudit.java (line 697)
<https://reviews.apache.org/r/37601/#comment150992>
"this.tags.equals(other.resourceType)" should be "this.tags.equals(other.tags)". Please review.
- Madhan Neethiraj
On Aug. 19, 2015, 7:28 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37601/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2015, 7:28 a.m.)
>
>
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-610
> https://issues.apache.org/jira/browse/RANGER-610
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Audit page updated with addition of 'Tags' column. (submitting the review on behalf of Gautam Borad)
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java 154d1c3
> security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 897ed5d
> security-admin/src/main/java/org/apache/ranger/entity/XXAccessAudit.java 6e35fa4
> security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java e5de160
> security-admin/src/main/java/org/apache/ranger/service/RangerPolicyServiceBase.java 9584c3d
> security-admin/src/main/java/org/apache/ranger/service/XAccessAuditService.java 98c987e
> security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 5fc45d2
> security-admin/src/main/java/org/apache/ranger/view/VXAccessAudit.java bcffd4d
> security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js b3147ee
>
> Diff: https://reviews.apache.org/r/37601/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Madhan Neethiraj
>
>