[GitHub] [accumulo] milleruntime edited a comment on issue #2187: Sorted Log Recovery configuration design

[GitBox <gi...@apache.org>]

milleruntime edited a comment on issue #2187:
URL: https://github.com/apache/accumulo/issues/2187#issuecomment-888497972


   What do you think about just one new prefix property as a catch all?
   <pre>
   TSERV_SORT_FILE_PREFIX("tserver.sort.file.", null, PropertyType.PREFIX,
         "The rfile properties to use when sorting logs during recovery. Most of the properties"
            + " that begin with 'table.file' can be used here. For example, to set the compression"
             + " of the sorted recovery files to snappy use 'tserver.sort.file.compress.type=snappy'",
         "2.1.0"),
   </pre>
   
   An RFileConfiguration object would be nice but we aren't using the RFile API for writing during the sorted recovery. I think we just need a prefix property and translate them to table properties in the constructor of LogSorter. This would allow using the table property validation and if a user specifies a valid property that is not used, it will just be ignored.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org