[GitHub] [orc] mystic-lama commented on a diff in pull request #1588: ORC-1483: [Java] Remove obsolete FileMetadata

["mystic-lama (via GitHub)" <gi...@apache.org>]

mystic-lama commented on code in PR #1588:
URL: https://github.com/apache/orc/pull/1588#discussion_r1297189413


##########
java/core/src/java/org/apache/orc/OrcFile.java:
##########
@@ -350,18 +346,6 @@ public KeyProvider getKeyProvider() {
       return keyProvider;
     }
 
-    /**
-     * @deprecated Use {@link #orcTail(OrcTail)} instead.
-     */
-    public ReaderOptions fileMetadata(final FileMetadata metadata) {
-      fileMetadata = metadata;
-      return this;
-    }
-
-    public FileMetadata getFileMetadata() {

Review Comment:
   Shall we mark this method as deprecated in early releases and then remove in 2.0?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org