You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "roubert (via GitHub)" <gi...@apache.org> on 2023/05/14 21:17:18 UTC
[GitHub] [directory-studio] roubert opened a new pull request, #43: DIRSTUDIO-1293: Add a native Apple silicon (aarch64) build target.
roubert opened a new pull request, #43:
URL: https://github.com/apache/directory-studio/pull/43
This is an alternate version of PR #36 in case the maintainers would prefer to keep using explicit version numbers here.
All unit tests (including `-Denable-ui-tests`) pass. Also tested manually on an M1 Mac with macOS _Ventura 13.3.1 (a)_.
Eclipse 4.24 is choosen because it's the newest version to which these libraries can be upgraded without having to make any other changes. Eclipse 4.25 causes a dependency error with JUnit (which eventually will need to be resolved, but isn't anything that needs to be done in order to resolve the Apple silicon issue).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
Re: [GitHub] [directory-studio] roubert commented on pull request #43: DIRSTUDIO-1309: Upgrade to Eclipse 4.24
Posted by Fredrik Roubert <fr...@roubert.name>.
On Sat 15 Jul 2023 at 20:40 -0000, roubert (via GitHub) wrote:
> https://github.com/apache/directory-studio/pull/43#issuecomment-1636882744
>
> I've now filed a separate ticket DIRSTUDIO-1309 specifically about
> updating the Eclipse platform used (unrelated to Apple silicon) and
> repurposed this PR for that.
I think that this update of Directory Studio to Eclipse platform 4.24
would be a good first step towards getting Directory Studio to a current
platform version. That's the last version that can be updated to without
first updating the Java version used.
What's the process for getting a PR like this one reviewed and merged?
Cheers // Fredrik Roubert
--
Forsterstrasse 64 | +41 78 8170377
CH-8044 Zürich | https://roubert.name/fredrik/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
[GitHub] [directory-studio] roubert commented on pull request #43: DIRSTUDIO-1293: Add a native Apple silicon (aarch64) build target.
Posted by "roubert (via GitHub)" <gi...@apache.org>.
roubert commented on PR #43:
URL: https://github.com/apache/directory-studio/pull/43#issuecomment-1585091642
> @roubert Have you get Shawn McKinney mail?
Yes, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
[GitHub] [directory-studio] roubert commented on pull request #43: DIRSTUDIO-1293: Add a native Apple silicon (aarch64) build target.
Posted by "roubert (via GitHub)" <gi...@apache.org>.
roubert commented on PR #43:
URL: https://github.com/apache/directory-studio/pull/43#issuecomment-1565568630
> I'll check if that breaks anything on i386.
Great! How is it going, are you finding any unexpected side-effects?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
Re: [PR] DIRSTUDIO-1309: Upgrade to Eclipse 4.24 [directory-studio]
Posted by "roubert (via GitHub)" <gi...@apache.org>.
roubert commented on PR #43:
URL: https://github.com/apache/directory-studio/pull/43#issuecomment-1946665393
@PierreSmits, now when you're upgrading dependenices, you might want to also merge this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
[GitHub] [directory-studio] elecharny commented on pull request #43: DIRSTUDIO-1293: Add a native Apple silicon (aarch64) build target.
Posted by "elecharny (via GitHub)" <gi...@apache.org>.
elecharny commented on PR #43:
URL: https://github.com/apache/directory-studio/pull/43#issuecomment-1547204723
Thanks, Frederick!
The pb is that we don't have a M1 or M2 based computer to test it...
If someone volunteers to tun self-hosted GitHub M1 runner, that would help
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
Re: [PR] DIRSTUDIO-1309: Upgrade to Eclipse 4.24 [directory-studio]
Posted by "roubert (via GitHub)" <gi...@apache.org>.
roubert commented on PR #43:
URL: https://github.com/apache/directory-studio/pull/43#issuecomment-1743751496
> The pb is that we don't have a M1 or M2 based computer to test it...
GitHub might just have solved that: https://github.blog/changelog/2023-10-02-github-actions-apple-silicon-m1-macos-runners-are-now-available-in-public-beta/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
[GitHub] [directory-studio] elecharny commented on pull request #43: DIRSTUDIO-1293: Add a native Apple silicon (aarch64) build target.
Posted by "elecharny (via GitHub)" <gi...@apache.org>.
elecharny commented on PR #43:
URL: https://github.com/apache/directory-studio/pull/43#issuecomment-1562259943
Hi Frederick, just merged your change! I'll check if that breaks anything on i386.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
Re: [PR] DIRSTUDIO-1309: Upgrade to Eclipse 4.24 [directory-studio]
Posted by "PierreSmits (via GitHub)" <gi...@apache.org>.
PierreSmits commented on PR #43:
URL: https://github.com/apache/directory-studio/pull/43#issuecomment-1946747087
Hi @roubert
According to my information you are a committer to this repository also. As such you can merge (valid) pull-request too.
However, I suggest to do a dummy commit to get this PR tested against latest changes in the main branch (given the age of this PR and recent upgrades).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
[GitHub] [directory-studio] roubert commented on pull request #43: DIRSTUDIO-1293: Upgrade to Eclipse 4.24
Posted by "roubert (via GitHub)" <gi...@apache.org>.
roubert commented on PR #43:
URL: https://github.com/apache/directory-studio/pull/43#issuecomment-1585093444
As I had this commit prepared, I've now updated the commit message in case you'd like to use it to update to Eclipse 4.24 (even though it now isn't needed to support Apple silicon anymore, after PR #36 was merged earlier today).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
Re: [PR] DIRSTUDIO-1309: Upgrade to Eclipse 4.24 [directory-studio]
Posted by "PierreSmits (via GitHub)" <gi...@apache.org>.
PierreSmits commented on PR #43:
URL: https://github.com/apache/directory-studio/pull/43#issuecomment-1947889977
Thanks @elecharny
My thoughts exactly. Our CI processes should safeguard that what gets merged in our trunk is good enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
[GitHub] [directory-studio] elecharny commented on pull request #43: DIRSTUDIO-1293: Add a native Apple silicon (aarch64) build target.
Posted by "elecharny (via GitHub)" <gi...@apache.org>.
elecharny commented on PR #43:
URL: https://github.com/apache/directory-studio/pull/43#issuecomment-1584119657
@roubert Have you get Shawn McKinney mail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
Re: [PR] DIRSTUDIO-1309: Upgrade to Eclipse 4.24 [directory-studio]
Posted by "roubert (via GitHub)" <gi...@apache.org>.
roubert commented on PR #43:
URL: https://github.com/apache/directory-studio/pull/43#issuecomment-1946847829
Well, I'm not used to merging things like a lone ranger, without anyone else in the project first reviewing and agreeing. But I've now rebased and will force push, to trigger tests at current master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
Re: [PR] DIRSTUDIO-1309: Upgrade to Eclipse 4.24 [directory-studio]
Posted by "elecharny (via GitHub)" <gi...@apache.org>.
elecharny commented on PR #43:
URL: https://github.com/apache/directory-studio/pull/43#issuecomment-1947858932
Hi @roubert,
please go ahead ! Break things, then get them fixed - either by you are someone else -. Don't be shy :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
[GitHub] [directory-studio] roubert commented on pull request #43: DIRSTUDIO-1293: Add a native Apple silicon (aarch64) build target.
Posted by "roubert (via GitHub)" <gi...@apache.org>.
roubert commented on PR #43:
URL: https://github.com/apache/directory-studio/pull/43#issuecomment-1547219149
To get things started, maybe you could just take my word for it that this works on M1. Then you'd only need to verify that it doesn't break any of the existing platforms.
Going forward, automated testing will of course be needed to prevent accidental regressions, but that is unfortunately not something that I could help out with, but once M1 support has been added and people start using it, maybe someone else will step up and help out, when they then have an interest in keeping it working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
[GitHub] [directory-studio] roubert commented on pull request #43: DIRSTUDIO-1309: Upgrade to Eclipse 4.24
Posted by "roubert (via GitHub)" <gi...@apache.org>.
roubert commented on PR #43:
URL: https://github.com/apache/directory-studio/pull/43#issuecomment-1636882744
I've now filed a separate ticket DIRSTUDIO-1309 specifically about updating the Eclipse platform used (unrelated to Apple silicon) and repurposed this PR for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
Re: [PR] DIRSTUDIO-1309: Upgrade to Eclipse 4.24 [directory-studio]
Posted by "PierreSmits (via GitHub)" <gi...@apache.org>.
PierreSmits merged PR #43:
URL: https://github.com/apache/directory-studio/pull/43
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org