[GitHub] [pulsar] leizhiyuan commented on a diff in pull request #15156: fix: wrong autoReadDisabledRateLimiting status when limit by maxPendingSendRequests

[GitBox <gi...@apache.org>]

leizhiyuan commented on code in PR #15156:
URL: https://github.com/apache/pulsar/pull/15156#discussion_r851735419


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##########
@@ -2647,7 +2647,7 @@ public void startSendOperation(Producer producer, int msgSize, int numMessages)
             // client connection, possibly shared between multiple producers
             ctx.channel().config().setAutoRead(false);
             recordRateLimitMetrics(producers);
-            autoReadDisabledRateLimiting = isPublishRateExceeded;
+            autoReadDisabledRateLimiting = true;

Review Comment:
   ok，maybe I misunderstand the design



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org