You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/06/04 00:53:51 UTC

[GitHub] [servicecomb-java-chassis] wujimin commented on a change in pull request #1815: [SCB-1971] minor change to fix an issue

wujimin commented on a change in pull request #1815:
URL: https://github.com/apache/servicecomb-java-chassis/pull/1815#discussion_r434933441



##########
File path: service-registry/registry-zero-config/src/main/java/org/apache/servicecomb/zeroconfig/ZeroConfigRegistration.java
##########
@@ -48,8 +48,8 @@
   private ZeroConfigClient zeroConfigClient = ZeroConfigClient.INSTANCE;
 
   // registration objects
-  private Microservice selfMicroservice;
-  private MicroserviceInstance selfMicroserviceInstance;
+  private static Microservice selfMicroservice;

Review comment:
       better not to use static variables




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org