You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Andrey Zagrebin (Jira)" <ji...@apache.org> on 2019/12/09 13:32:00 UTC

[jira] [Commented] (FLINK-15146) The value of `cleanupSize` should be grater than 0 for `IncrementalCleanupStrategy`

    [ https://issues.apache.org/jira/browse/FLINK-15146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16991588#comment-16991588 ] 

Andrey Zagrebin commented on FLINK-15146:
-----------------------------------------

[~hehuiyuan] 
I think you are right, although technically zero value will not break the cleanup but practically there will be no cleanup.

We can change cleanupSize to be strictly greater than zero to avoid confusion.

Do you want to work on this?

> The value of `cleanupSize` should be grater than 0 for `IncrementalCleanupStrategy`
> -----------------------------------------------------------------------------------
>
>                 Key: FLINK-15146
>                 URL: https://issues.apache.org/jira/browse/FLINK-15146
>             Project: Flink
>          Issue Type: Wish
>            Reporter: hehuiyuan
>            Priority: Minor
>         Attachments: image-2019-12-09-17-03-59-014.png, image-2019-12-09-17-09-18-062.png
>
>
>  
> Hi , the value of cleanupSize is grater than or equal 0. Whether that the value is grater than 0 is more practical.
> !image-2019-12-09-17-03-59-014.png|width=615,height=108!
> !image-2019-12-09-17-09-18-062.png|width=491,height=309!
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)