You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Alex Rudyy (Created) (JIRA)" <ji...@apache.org> on 2011/10/05 17:49:34 UTC
[jira] [Created] (QPID-3527) Messages may not acknowledged
immediately after receiving in AUTO_ACKNOWLEDGE mode on 0-10 client
Messages may not acknowledged immediately after receiving in AUTO_ACKNOWLEDGE mode on 0-10 client
-------------------------------------------------------------------------------------------------
Key: QPID-3527
URL: https://issues.apache.org/jira/browse/QPID-3527
Project: Qpid
Issue Type: Bug
Components: Java Client
Affects Versions: 0.12, 0.11, 0.10, 0.9, 0.8, 0.7, 0.6, 0.5
Reporter: Alex Rudyy
Fix For: 0.13
In AUTO_ACKNOWLEDGE mode on 0-10 client messages may not acknowledged immediately after receiving. The message acknowledgement in AA mode is implemented in lazy fashion with flusher thread. As result of it, the acknowledgement might happened in 1 second (by default) after receiving the message.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Resolved] (QPID-3527) Messages may not acknowledged
immediately after receiving in AUTO_ACKNOWLEDGE mode on 0-10 client
Posted by "Robbie Gemmell (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell resolved QPID-3527.
----------------------------------
Resolution: Fixed
> Messages may not acknowledged immediately after receiving in AUTO_ACKNOWLEDGE mode on 0-10 client
> -------------------------------------------------------------------------------------------------
>
> Key: QPID-3527
> URL: https://issues.apache.org/jira/browse/QPID-3527
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.5, 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12
> Reporter: Alex Rudyy
> Assignee: Robbie Gemmell
> Fix For: 0.13
>
> Attachments: 0003-QPID-3527-update-handling-of-auto-ack-messages-for-0.patch
>
>
> In AUTO_ACKNOWLEDGE mode on 0-10 client messages may not acknowledged immediately after receiving. The message acknowledgement in AA mode is implemented in lazy fashion with flusher thread. As result of it, the acknowledgement might happened in 1 second (by default) after receiving the message.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Assigned] (QPID-3527) Messages may not acknowledged
immediately after receiving in AUTO_ACKNOWLEDGE mode on 0-10 client
Posted by "Alex Rudyy (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Rudyy reassigned QPID-3527:
--------------------------------
Assignee: Alex Rudyy
> Messages may not acknowledged immediately after receiving in AUTO_ACKNOWLEDGE mode on 0-10 client
> -------------------------------------------------------------------------------------------------
>
> Key: QPID-3527
> URL: https://issues.apache.org/jira/browse/QPID-3527
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.5, 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12
> Reporter: Alex Rudyy
> Assignee: Alex Rudyy
> Fix For: 0.13
>
> Attachments: 0003-QPID-3527-update-handling-of-auto-ack-messages-for-0.patch
>
>
> In AUTO_ACKNOWLEDGE mode on 0-10 client messages may not acknowledged immediately after receiving. The message acknowledgement in AA mode is implemented in lazy fashion with flusher thread. As result of it, the acknowledgement might happened in 1 second (by default) after receiving the message.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3527) Messages may not acknowledged
immediately after receiving in AUTO_ACKNOWLEDGE mode on 0-10 client
Posted by "Alex Rudyy (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Rudyy updated QPID-3527:
-----------------------------
Status: Ready To Review (was: In Progress)
> Messages may not acknowledged immediately after receiving in AUTO_ACKNOWLEDGE mode on 0-10 client
> -------------------------------------------------------------------------------------------------
>
> Key: QPID-3527
> URL: https://issues.apache.org/jira/browse/QPID-3527
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.5, 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12
> Reporter: Alex Rudyy
> Assignee: Alex Rudyy
> Fix For: 0.13
>
> Attachments: 0003-QPID-3527-update-handling-of-auto-ack-messages-for-0.patch
>
>
> In AUTO_ACKNOWLEDGE mode on 0-10 client messages may not acknowledged immediately after receiving. The message acknowledgement in AA mode is implemented in lazy fashion with flusher thread. As result of it, the acknowledgement might happened in 1 second (by default) after receiving the message.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3527) Messages may not acknowledged
immediately after receiving in AUTO_ACKNOWLEDGE mode on 0-10 client
Posted by "Robbie Gemmell (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122657#comment-13122657 ]
Robbie Gemmell commented on QPID-3527:
--------------------------------------
Patch applied. Auto-ack now results in sending asynchronous acks after each message is delivered to the application.
> Messages may not acknowledged immediately after receiving in AUTO_ACKNOWLEDGE mode on 0-10 client
> -------------------------------------------------------------------------------------------------
>
> Key: QPID-3527
> URL: https://issues.apache.org/jira/browse/QPID-3527
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.5, 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12
> Reporter: Alex Rudyy
> Assignee: Robbie Gemmell
> Fix For: 0.13
>
> Attachments: 0003-QPID-3527-update-handling-of-auto-ack-messages-for-0.patch
>
>
> In AUTO_ACKNOWLEDGE mode on 0-10 client messages may not acknowledged immediately after receiving. The message acknowledgement in AA mode is implemented in lazy fashion with flusher thread. As result of it, the acknowledgement might happened in 1 second (by default) after receiving the message.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Assigned] (QPID-3527) Messages may not acknowledged
immediately after receiving in AUTO_ACKNOWLEDGE mode on 0-10 client
Posted by "Alex Rudyy (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Rudyy reassigned QPID-3527:
--------------------------------
Assignee: Robbie Gemmell (was: Alex Rudyy)
Robbie, could you please review and apply the patch attached?
> Messages may not acknowledged immediately after receiving in AUTO_ACKNOWLEDGE mode on 0-10 client
> -------------------------------------------------------------------------------------------------
>
> Key: QPID-3527
> URL: https://issues.apache.org/jira/browse/QPID-3527
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.5, 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12
> Reporter: Alex Rudyy
> Assignee: Robbie Gemmell
> Fix For: 0.13
>
> Attachments: 0003-QPID-3527-update-handling-of-auto-ack-messages-for-0.patch
>
>
> In AUTO_ACKNOWLEDGE mode on 0-10 client messages may not acknowledged immediately after receiving. The message acknowledgement in AA mode is implemented in lazy fashion with flusher thread. As result of it, the acknowledgement might happened in 1 second (by default) after receiving the message.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3527) Messages may not acknowledged
immediately after receiving in AUTO_ACKNOWLEDGE mode on 0-10 client
Posted by "Rajith Attapattu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121309#comment-13121309 ]
Rajith Attapattu commented on QPID-3527:
----------------------------------------
Actually acknowledgement happens in two ways (based on which ever happens first).
1. Based on the prefetch (or credit window)
2. Based on the ack-flusher thread
First of all, the current behaviour is incorrect as it's the same as DUPS ok.
The first method was to ack every time the number of unacked messages exceeded more than half the credit window (or prefetch value). I don't know the reasons behind why it was done this way. I am guessing performance.
The second method was added by myself as I found when there is a large prefetch window, but with very slow message flows, no acks are sent at all. And often when the client fails over all most all messages are replayed. The ack flusher thread prevented that from happening.
When we fix this issue, we would need to ensure we consider performance. We should also make some noise about this change in the release notes to ensure we don't catch any folks by surprise.
> Messages may not acknowledged immediately after receiving in AUTO_ACKNOWLEDGE mode on 0-10 client
> -------------------------------------------------------------------------------------------------
>
> Key: QPID-3527
> URL: https://issues.apache.org/jira/browse/QPID-3527
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.5, 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12
> Reporter: Alex Rudyy
> Fix For: 0.13
>
>
> In AUTO_ACKNOWLEDGE mode on 0-10 client messages may not acknowledged immediately after receiving. The message acknowledgement in AA mode is implemented in lazy fashion with flusher thread. As result of it, the acknowledgement might happened in 1 second (by default) after receiving the message.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3527) Messages may not acknowledged
immediately after receiving in AUTO_ACKNOWLEDGE mode on 0-10 client
Posted by "Alex Rudyy (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Rudyy updated QPID-3527:
-----------------------------
Attachment: 0003-QPID-3527-update-handling-of-auto-ack-messages-for-0.patch
Attached patche from Robbie Gemmell and me fixing the issue.
> Messages may not acknowledged immediately after receiving in AUTO_ACKNOWLEDGE mode on 0-10 client
> -------------------------------------------------------------------------------------------------
>
> Key: QPID-3527
> URL: https://issues.apache.org/jira/browse/QPID-3527
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.5, 0.6, 0.7, 0.8, 0.9, 0.10, 0.11, 0.12
> Reporter: Alex Rudyy
> Assignee: Alex Rudyy
> Fix For: 0.13
>
> Attachments: 0003-QPID-3527-update-handling-of-auto-ack-messages-for-0.patch
>
>
> In AUTO_ACKNOWLEDGE mode on 0-10 client messages may not acknowledged immediately after receiving. The message acknowledgement in AA mode is implemented in lazy fashion with flusher thread. As result of it, the acknowledgement might happened in 1 second (by default) after receiving the message.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org