[GitHub] [tvm] cbalint13 commented on pull request #15685: [Target][TOPI] Use LLVM for x86 CPU feature lookup

["cbalint13 (via GitHub)" <gi...@apache.org>]

cbalint13 commented on PR #15685:
URL: https://github.com/apache/tvm/pull/15685#issuecomment-1711439202

   > The CI fails because the LLVM version on CI is pretty low (==10). I'm curious if there's any variant of this API on LLVM 10? If not, we should bump LLVM to 15 or 16
   
   Folks,
     @junrushao ,
   
   Yes, I am aware of this ```llvm<=10``` issue, so ```llvm==11``` would be the minimum (tested).
   Looking at ```llvm<=10``` to see other way (little +extra code costs) of tapping differently into their API.
   
   I am strongly opting for a backward compatibility for this case.
   
   The API fracture, at a first glance:
     * ```llvm>=11``` expose/uses a [c_struct](https://github.com/llvm/llvm-project/blob/llvmorg-16.0.0/llvm/lib/TargetParser/X86TargetParser.cpp#L119) + a nice func ```X86::getFeaturesForCPU``` to it.
     * ```llvm<=10``` expose a [tablegen](https://github.com/llvm/llvm-project/blob/llvmorg-10.0.0/llvm/lib/Target/X86/X86.td#L514) (same info) so need to see where it ends to use that via some API.
   
   
   Allow a little time (1-2 day) to investigate a way going down ```llvm<11```, then I'll be back with the results.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org