[GitHub] [spark] dtenedor commented on pull request #36365: [SPARK-28516][SQL] Implement `to_char` and `try_to_char` functions to format Decimal values as strings

[GitBox <gi...@apache.org>]

dtenedor commented on PR #36365:
URL: https://github.com/apache/spark/pull/36365#issuecomment-1120307824

   @cloud-fan I've updated this PR according to the latest approved spec at go/to-char, please take a look. In particular, new changes include:
   
   * The result string is always the same length as the format string, so spaces are inserted before or after the decimal point as necessary.
   * If the input Decimal value contains more digits before or after the decimal point than the format string, this is considered an overflow and prints `#` for those digits rather than returning a runtime error (this behavior is consistent with existing engines).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org