[jira] [Resolved] (ARROW-5754) [C++]Missing override for ~GrpcStreamWriter?

["Micah Kornfield (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARROW-5754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Micah Kornfield resolved ARROW-5754.
------------------------------------
       Resolution: Fixed
    Fix Version/s: 0.14.0

Issue resolved by pull request 4716
[https://github.com/apache/arrow/pull/4716]

> [C++]Missing override for ~GrpcStreamWriter?
> --------------------------------------------
>
>                 Key: ARROW-5754
>                 URL: https://issues.apache.org/jira/browse/ARROW-5754
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++
>            Reporter: Kenta Murata
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.14.0
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> I encountered the following compile error:
> {noformat}
> ../src/arrow/flight/client.cc:244:3: error: '~GrpcStreamWriter' overrides a destructor but is not marked 'override' [-Werror,-Winconsistent-missing-destructor-override]
>   ~GrpcStreamWriter() = default;
>   ^
> ../src/arrow/flight/client.h:86:27: note: overridden virtual function is here
> class ARROW_FLIGHT_EXPORT FlightStreamWriter : public ipc::RecordBatchWriter {
>                           ^
> {noformat}
> Putting override modifier can resolve this problem.
>  I'll make a pull-request for the change.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)