[PATCH] Fix confusing comments introduced in r16476

[Malcolm Rowe <ma...@farside.org.uk>]

Hi Peter,

I'm really not trying to pick on your commit, honest! But this one had
me confused for ages; please consider applying.

Part of the commit for r16476 re-wrapped a call to
svn__client_get_diff_editor(), but in doing so it made the end-of-line
comments look like they applied to the following arguments. I've just
spent a while trying to work out why we bother opening a second RA
session, if it "doesn't matter for diff".  Please fix, for my sanity,
if nothing else!

[[[
* subversion/libsvn_client/diff.c
  (diff_repos_repos): Make it clear which argument the comments refer to.
]]]

Regards,
Malcolm

Re: [PATCH] Fix confusing comments introduced in r16476

["Peter N. Lundblad" <pe...@famlundblad.se>]

On Fri, 7 Oct 2005, Malcolm Rowe wrote:

> I'm really not trying to pick on your commit, honest! But this one had
> me confused for ages; please consider applying.
>
Your reviews are always welcome, I don't take them personally (in most
cases:-).

I committed this and the next comment clarification patch in r16566.

thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org