You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "eldenmoon (via GitHub)" <gi...@apache.org> on 2023/11/10 09:58:06 UTC

[PR] [Fix](row store) cache invalidate key should not include sequence column [doris]

eldenmoon opened a new pull request, #26771:
URL: https://github.com/apache/doris/pull/26771

   Other wise the key loaded cache with is without sequence column, and lead to stale data read
   
   ## Proposed changes
   
   Issue Number: close #xxx
   
   <!--Describe your changes.-->
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](row store) cache invalidate key should not include sequence column [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26771:
URL: https://github.com/apache/doris/pull/26771#issuecomment-1805666494

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](row store) cache invalidate key should not include sequence column [doris]

Posted by "xiaokang (via GitHub)" <gi...@apache.org>.
xiaokang merged PR #26771:
URL: https://github.com/apache/doris/pull/26771


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](row store) cache invalidate key should not include sequence column [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26771:
URL: https://github.com/apache/doris/pull/26771#issuecomment-1806731367

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](row store) cache invalidate key should not include sequence column [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #26771:
URL: https://github.com/apache/doris/pull/26771#issuecomment-1805502537

   
   <details>
   <summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
   
   ```
   Tpch sf100 test result on commit 4c3ba8a043e5adceed1510835fa6a744b50de44b, data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1	5186	5278	5189	5189
   q2	373	189	199	189
   q3	2092	2048	2046	2046
   q4	1473	1408	1432	1408
   q5	4128	4178	4126	4126
   q6	254	134	136	134
   q7	2106	1614	1631	1614
   q8	2767	2778	2776	2776
   q9	10340	10372	10244	10244
   q10	3477	3562	3578	3562
   q11	377	245	254	245
   q12	467	296	306	296
   q13	4530	4133	4061	4061
   q14	342	302	285	285
   q15	618	543	558	543
   q16	698	627	607	607
   q17	1158	1127	1112	1112
   q18	7785	7335	7464	7335
   q19	1717	1706	1713	1706
   q20	582	366	357	357
   q21	4956	4593	4607	4593
   q22	537	430	452	430
   Total cold run time: 55963 ms
   Total hot run time: 52858 ms
   
   run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
   q1	5016	5031	4995	4995
   q2	336	237	240	237
   q3	4007	3964	3977	3964
   q4	2769	2751	2728	2728
   q5	6499	6503	6555	6503
   q6	243	125	124	124
   q7	3145	2726	2759	2726
   q8	4787	4934	4796	4796
   q9	17759	17599	17748	17599
   q10	4076	4138	4156	4138
   q11	742	663	633	633
   q12	1016	820	849	820
   q13	4311	3939	3872	3872
   q14	379	372	342	342
   q15	633	537	561	537
   q16	808	675	717	675
   q17	3870	3888	3966	3888
   q18	9525	9115	9294	9115
   q19	1900	1791	1802	1791
   q20	2377	2043	2045	2043
   q21	8790	8643	8757	8643
   q22	1016	876	848	848
   Total cold run time: 84004 ms
   Total hot run time: 81017 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](row store) cache invalidate key should not include sequence column [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #26771:
URL: https://github.com/apache/doris/pull/26771#issuecomment-1805540119

   TeamCity be ut coverage result:
    Function Coverage: 36.77% (8404/22856) 
    Line Coverage: 29.28% (68135/232682)
    Region Coverage: 27.91% (35214/126188)
    Branch Coverage: 24.73% (18017/72854)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/4c3ba8a043e5adceed1510835fa6a744b50de44b_4c3ba8a043e5adceed1510835fa6a744b50de44b/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](row store) cache invalidate key should not include sequence column [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26771:
URL: https://github.com/apache/doris/pull/26771#issuecomment-1805440191

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](row store) cache invalidate key should not include sequence column [doris]

Posted by "eldenmoon (via GitHub)" <gi...@apache.org>.
eldenmoon commented on PR #26771:
URL: https://github.com/apache/doris/pull/26771#issuecomment-1805441805

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](row store) cache invalidate key should not include sequence column [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #26771:
URL: https://github.com/apache/doris/pull/26771#issuecomment-1805501320

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 45.4 seconds
    stream load tsv:          558 seconds loaded 74807831229 Bytes, about 127 MB/s
    stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
    stream load orc:          65 seconds loaded 1101869774 Bytes, about 16 MB/s
    stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
    insert into select:          28.9 seconds inserted 10000000 Rows, about 346K ops/s
    storage size: 17162318053 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org