You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "0yukali0 (via GitHub)" <gi...@apache.org> on 2023/02/18 09:52:15 UTC
[GitHub] [yunikorn-k8shim] 0yukali0 opened a new pull request, #537: [YUNIKORN-1580] Upgrade github.com/looplab/fsm to stable version
0yukali0 opened a new pull request, #537:
URL: https://github.com/apache/yunikorn-k8shim/pull/537
### What is this PR for?
Upgrading [github.com/looplab/fsm](https://github.com/looplab/fsm) from v0.1.0 to v1.0.1.
The difference between v0.1.0 and v1.0.1 is following:
1. parameters of callback function are different. [v0.1.0 def](https://github.com/looplab/fsm/blob/v0.1.0/fsm.go#L82) v.s. [v1.0.1](https://github.com/looplab/fsm/blob/v1.0.1/fsm.go#L87)
2. parameters of ism.Event are different. [v0.1.0 def](https://github.com/looplab/fsm/blob/v1.0.1/fsm.go#L296) v.s. [v1.0.1](https://github.com/looplab/fsm/blob/v0.1.0/fsm.go#L269)
### What type of PR is it?
* [ ] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
* [x] - Task
### What is the Jira issue?
[* Opeheduling interface parameters`](https://issues.apache.org/jira/browse/YUNIKORN-1580)
### How should this be tested?
If the YUNIKORN-1580 in core side is not be merged, you need to clone the YUNIKORN-1580 in core.
1. modifying the `go.mod` require and redirect the core dependency to local core rep.
2. `make test`
If the YUNIKORN-1580 in core side is merged, only one thing is to try the command `make test`
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] 0yukali0 commented on pull request #537: [YUNIKORN-1580] Upgrade github.com/looplab/fsm to stable version
Posted by "0yukali0 (via GitHub)" <gi...@apache.org>.
0yukali0 commented on PR #537:
URL: https://github.com/apache/yunikorn-k8shim/pull/537#issuecomment-1439726163
Updating the package dependency.
Core version is latest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] 0yukali0 commented on pull request #537: [YUNIKORN-1580] Upgrade github.com/looplab/fsm to stable version
Posted by "0yukali0 (via GitHub)" <gi...@apache.org>.
0yukali0 commented on PR #537:
URL: https://github.com/apache/yunikorn-k8shim/pull/537#issuecomment-1435581864
Expected failure is because the [modification](https://github.com/apache/yunikorn-core/pull/508) in core side is not merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] 0yukali0 commented on pull request #537: [YUNIKORN-1580] Upgrade github.com/looplab/fsm to stable version
Posted by "0yukali0 (via GitHub)" <gi...@apache.org>.
0yukali0 commented on PR #537:
URL: https://github.com/apache/yunikorn-k8shim/pull/537#issuecomment-1439635320
YUNIKOR-1580 in core side was merged and the fsm version problem in core side does not exist.
I restart the Pre-commit check and the unit test step will pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] wilfred-s closed pull request #537: [YUNIKORN-1580] Upgrade github.com/looplab/fsm to stable version
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s closed pull request #537: [YUNIKORN-1580] Upgrade github.com/looplab/fsm to stable version
URL: https://github.com/apache/yunikorn-k8shim/pull/537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #537: [YUNIKORN-1580] Upgrade github.com/looplab/fsm to stable version
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #537:
URL: https://github.com/apache/yunikorn-k8shim/pull/537#issuecomment-1439727250
# [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/537?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#537](https://codecov.io/gh/apache/yunikorn-k8shim/pull/537?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c8b22b5) into [master](https://codecov.io/gh/apache/yunikorn-k8shim/commit/9e650c6d3162190443c0cc4dee1c80f1db3a34db?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9e650c6) will **decrease** coverage by `0.03%`.
> The diff coverage is `81.08%`.
```diff
@@ Coverage Diff @@
## master #537 +/- ##
==========================================
- Coverage 69.55% 69.52% -0.03%
==========================================
Files 45 45
Lines 7715 7715
==========================================
- Hits 5366 5364 -2
- Misses 2153 2155 +2
Partials 196 196
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-k8shim/pull/537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/cache/task\_state.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL3Rhc2tfc3RhdGUuZ28=) | `70.29% <70.00%> (ø)` | |
| [pkg/cache/application\_state.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uX3N0YXRlLmdv) | `90.18% <72.72%> (ø)` | |
| [pkg/shim/scheduler\_state.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NoaW0vc2NoZWR1bGVyX3N0YXRlLmdv) | `91.39% <85.71%> (ø)` | |
| [pkg/cache/application.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `75.36% <100.00%> (ø)` | |
| [pkg/cache/node.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL25vZGUuZ28=) | `86.77% <100.00%> (ø)` | |
| [pkg/cache/node\_state.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL25vZGVfc3RhdGUuZ28=) | `97.50% <100.00%> (ø)` | |
| [pkg/cache/task.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL3Rhc2suZ28=) | `68.81% <100.00%> (ø)` | |
| [pkg/shim/scheduler.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NoaW0vc2NoZWR1bGVyLmdv) | `72.85% <100.00%> (ø)` | |
| [pkg/dispatcher/dispatcher.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2Rpc3BhdGNoZXIvZGlzcGF0Y2hlci5nbw==) | `74.82% <0.00%> (-1.40%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] 0yukali0 commented on pull request #537: [YUNIKORN-1580] Upgrade github.com/looplab/fsm to stable version
Posted by "0yukali0 (via GitHub)" <gi...@apache.org>.
0yukali0 commented on PR #537:
URL: https://github.com/apache/yunikorn-k8shim/pull/537#issuecomment-1439702326
Hi @wilfred-s , how do change the core version to the latest version of core?
I successfully ran the UT in k8shim with the latest core which I cloned from the apache/yunikorn-core:master.
<img width="1125" alt="image" src="https://user-images.githubusercontent.com/45888688/220580598-1a30beff-a1d8-49cc-a7a6-e651d5e5e5fb.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org