You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Amar Kamat (JIRA)" <ji...@apache.org> on 2008/03/27 05:47:24 UTC
[jira] Created: (HADOOP-3101) 'bin/hadoop job' should display the
help and silently exit
'bin/hadoop job' should display the help and silently exit
----------------------------------------------------------
Key: HADOOP-3101
URL: https://issues.apache.org/jira/browse/HADOOP-3101
Project: Hadoop Core
Issue Type: Bug
Reporter: Amar Kamat
Priority: Minor
Currently 'bin/hadoop job' displays help and throws an exception. Like other commands (e.g dfs) it should silently come out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (HADOOP-3101) 'bin/hadoop job' should display the help and silently exit
Posted by "Edward J. Yoon" <ed...@udanax.org>.
Does anyone care to give a review?
On Mon, Apr 21, 2008 at 7:22 AM, Hadoop QA (JIRA) <ji...@apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/HADOOP-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590814#action_12590814 ]
>
> Hadoop QA commented on HADOOP-3101:
> -----------------------------------
>
> +1 overall. Here are the results of testing the latest attachment
> http://issues.apache.org/jira/secure/attachment/12380472/3101_v03.patch
> against trunk revision 645773.
>
> @author +1. The patch does not contain any @author tags.
>
> tests included +1. The patch appears to include 4 new or modified tests.
>
> javadoc +1. The javadoc tool did not generate any warning messages.
>
> javac +1. The applied patch does not generate any new javac compiler warnings.
>
> release audit +1. The applied patch does not generate any new release audit warnings.
>
> findbugs +1. The patch does not introduce any new Findbugs warnings.
>
> core tests +1. The patch passed core unit tests.
>
> contrib tests +1. The patch passed contrib unit tests.
>
> Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2286/testReport/
> Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2286/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
> Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2286/artifact/trunk/build/test/checkstyle-errors.html
> Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2286/console
>
> This message is automatically generated.
>
> > 'bin/hadoop job' should display the help and silently exit
> > ----------------------------------------------------------
> >
> > Key: HADOOP-3101
> > URL: https://issues.apache.org/jira/browse/HADOOP-3101
> > Project: Hadoop Core
> > Issue Type: Bug
> > Reporter: Amar Kamat
> > Assignee: Edward J. Yoon
> > Priority: Minor
> > Attachments: 3101.patch, 3101_v02.patch, 3101_v03.patch
>
> >
> >
> > Currently 'bin/hadoop job' displays help and throws an exception. Like other commands (e.g dfs) it should silently come out.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
--
B. Regards,
Edward J. Yoon
[jira] Commented: (HADOOP-3101) 'bin/hadoop job' should display the
help and silently exit
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586332#action_12586332 ]
Edward J. Yoon commented on HADOOP-3101:
----------------------------------------
Oh, I see. Thanks.
BTW, do we need to test them?
> 'bin/hadoop job' should display the help and silently exit
> ----------------------------------------------------------
>
> Key: HADOOP-3101
> URL: https://issues.apache.org/jira/browse/HADOOP-3101
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Amar Kamat
> Assignee: Edward J. Yoon
> Priority: Minor
> Attachments: 3101.patch
>
>
> Currently 'bin/hadoop job' displays help and throws an exception. Like other commands (e.g dfs) it should silently come out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-3101) 'bin/hadoop job' should display the
help and silently exit
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon reassigned HADOOP-3101:
--------------------------------------
Assignee: Edward J. Yoon
> 'bin/hadoop job' should display the help and silently exit
> ----------------------------------------------------------
>
> Key: HADOOP-3101
> URL: https://issues.apache.org/jira/browse/HADOOP-3101
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Amar Kamat
> Assignee: Edward J. Yoon
> Priority: Minor
>
> Currently 'bin/hadoop job' displays help and throws an exception. Like other commands (e.g dfs) it should silently come out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3101) 'bin/hadoop job' should display the
help and silently exit
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HADOOP-3101:
-----------------------------------
Attachment: 3101_v04.patch
Thanks.
>> getRemainingArgs probably shouldn't return null
Yeh, i fixed it.
> 'bin/hadoop job' should display the help and silently exit
> ----------------------------------------------------------
>
> Key: HADOOP-3101
> URL: https://issues.apache.org/jira/browse/HADOOP-3101
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Amar Kamat
> Assignee: Edward J. Yoon
> Priority: Minor
> Fix For: 0.18.0
>
> Attachments: 3101.patch, 3101_v02.patch, 3101_v03.patch, 3101_v04.patch
>
>
> Currently 'bin/hadoop job' displays help and throws an exception. Like other commands (e.g dfs) it should silently come out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3101) 'bin/hadoop job' should display the
help and silently exit
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HADOOP-3101:
-----------------------------------
Attachment: 3101.patch
> 'bin/hadoop job' should display the help and silently exit
> ----------------------------------------------------------
>
> Key: HADOOP-3101
> URL: https://issues.apache.org/jira/browse/HADOOP-3101
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Amar Kamat
> Assignee: Edward J. Yoon
> Priority: Minor
> Attachments: 3101.patch
>
>
> Currently 'bin/hadoop job' displays help and throws an exception. Like other commands (e.g dfs) it should silently come out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3101) 'bin/hadoop job' should display the
help and silently exit
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HADOOP-3101:
-----------------------------------
Attachment: 3101_v02.patch
When GnuParser options parsing failed, commandLine doesn't defined.
> 'bin/hadoop job' should display the help and silently exit
> ----------------------------------------------------------
>
> Key: HADOOP-3101
> URL: https://issues.apache.org/jira/browse/HADOOP-3101
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Amar Kamat
> Assignee: Edward J. Yoon
> Priority: Minor
> Attachments: 3101.patch, 3101_v02.patch
>
>
> Currently 'bin/hadoop job' displays help and throws an exception. Like other commands (e.g dfs) it should silently come out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3101) 'bin/hadoop job' should display the
help and silently exit
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12592717#action_12592717 ]
Hadoop QA commented on HADOOP-3101:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12381007/3101_v04.patch
against trunk revision 645773.
@author +1. The patch does not contain any @author tags.
tests included +1. The patch appears to include 4 new or modified tests.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler warnings.
release audit +1. The applied patch does not generate any new release audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2337/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2337/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2337/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2337/console
This message is automatically generated.
> 'bin/hadoop job' should display the help and silently exit
> ----------------------------------------------------------
>
> Key: HADOOP-3101
> URL: https://issues.apache.org/jira/browse/HADOOP-3101
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Amar Kamat
> Assignee: Edward J. Yoon
> Priority: Minor
> Fix For: 0.18.0
>
> Attachments: 3101.patch, 3101_v02.patch, 3101_v03.patch, 3101_v04.patch
>
>
> Currently 'bin/hadoop job' displays help and throws an exception. Like other commands (e.g dfs) it should silently come out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3101) 'bin/hadoop job' should display the
help and silently exit
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HADOOP-3101:
-----------------------------------
Status: Patch Available (was: Open)
Submitting.
> 'bin/hadoop job' should display the help and silently exit
> ----------------------------------------------------------
>
> Key: HADOOP-3101
> URL: https://issues.apache.org/jira/browse/HADOOP-3101
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Amar Kamat
> Assignee: Edward J. Yoon
> Priority: Minor
> Attachments: 3101.patch, 3101_v02.patch, 3101_v03.patch
>
>
> Currently 'bin/hadoop job' displays help and throws an exception. Like other commands (e.g dfs) it should silently come out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3101) 'bin/hadoop job' should display the
help and silently exit
Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586323#action_12586323 ]
Amar Kamat commented on HADOOP-3101:
------------------------------------
Three comments
1) You can delete the {{throw IOException}} statement instead of commenting it out.
2) Because of spaces there is a diff generated (line 29 and 32 of the patch). I think we can avoid that.
3) Plz document the change made in {{GenericOptionsParser.java}} in the javadoc. Btw {{getRemainingArgs()}} is a public api and there is a change is what it returns. Should there be a concern?
Rest looks good.
> 'bin/hadoop job' should display the help and silently exit
> ----------------------------------------------------------
>
> Key: HADOOP-3101
> URL: https://issues.apache.org/jira/browse/HADOOP-3101
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Amar Kamat
> Assignee: Edward J. Yoon
> Priority: Minor
> Attachments: 3101.patch
>
>
> Currently 'bin/hadoop job' displays help and throws an exception. Like other commands (e.g dfs) it should silently come out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3101) 'bin/hadoop job' should display the
help and silently exit
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12592858#action_12592858 ]
Chris Douglas commented on HADOOP-3101:
---------------------------------------
+1 Looks good
> 'bin/hadoop job' should display the help and silently exit
> ----------------------------------------------------------
>
> Key: HADOOP-3101
> URL: https://issues.apache.org/jira/browse/HADOOP-3101
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Amar Kamat
> Assignee: Edward J. Yoon
> Priority: Minor
> Fix For: 0.18.0
>
> Attachments: 3101.patch, 3101_v02.patch, 3101_v03.patch, 3101_v04.patch
>
>
> Currently 'bin/hadoop job' displays help and throws an exception. Like other commands (e.g dfs) it should silently come out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3101) 'bin/hadoop job' should display the
help and silently exit
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12591889#action_12591889 ]
Edward J. Yoon commented on HADOOP-3101:
----------------------------------------
Does anyone care to give a review&commit?
> 'bin/hadoop job' should display the help and silently exit
> ----------------------------------------------------------
>
> Key: HADOOP-3101
> URL: https://issues.apache.org/jira/browse/HADOOP-3101
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Amar Kamat
> Assignee: Edward J. Yoon
> Priority: Minor
> Fix For: 0.18.0
>
> Attachments: 3101.patch, 3101_v02.patch, 3101_v03.patch
>
>
> Currently 'bin/hadoop job' displays help and throws an exception. Like other commands (e.g dfs) it should silently come out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3101) 'bin/hadoop job' should display the
help and silently exit
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12592480#action_12592480 ]
Chris Douglas commented on HADOOP-3101:
---------------------------------------
This looks good, but getRemainingArgs probably shouldn't return null, but rather an empty array. Applications checking argv.length in their own run() method will throw a NPE instead of their expected behavior.
> 'bin/hadoop job' should display the help and silently exit
> ----------------------------------------------------------
>
> Key: HADOOP-3101
> URL: https://issues.apache.org/jira/browse/HADOOP-3101
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Amar Kamat
> Assignee: Edward J. Yoon
> Priority: Minor
> Fix For: 0.18.0
>
> Attachments: 3101.patch, 3101_v02.patch, 3101_v03.patch
>
>
> Currently 'bin/hadoop job' displays help and throws an exception. Like other commands (e.g dfs) it should silently come out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3101) 'bin/hadoop job' should display the
help and silently exit
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-3101:
----------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thanks Edward
> 'bin/hadoop job' should display the help and silently exit
> ----------------------------------------------------------
>
> Key: HADOOP-3101
> URL: https://issues.apache.org/jira/browse/HADOOP-3101
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Amar Kamat
> Assignee: Edward J. Yoon
> Priority: Minor
> Fix For: 0.18.0
>
> Attachments: 3101.patch, 3101_v02.patch, 3101_v03.patch, 3101_v04.patch
>
>
> Currently 'bin/hadoop job' displays help and throws an exception. Like other commands (e.g dfs) it should silently come out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3101) 'bin/hadoop job' should display the
help and silently exit
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HADOOP-3101:
-----------------------------------
Fix Version/s: 0.18.0
> 'bin/hadoop job' should display the help and silently exit
> ----------------------------------------------------------
>
> Key: HADOOP-3101
> URL: https://issues.apache.org/jira/browse/HADOOP-3101
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Amar Kamat
> Assignee: Edward J. Yoon
> Priority: Minor
> Fix For: 0.18.0
>
> Attachments: 3101.patch, 3101_v02.patch, 3101_v03.patch
>
>
> Currently 'bin/hadoop job' displays help and throws an exception. Like other commands (e.g dfs) it should silently come out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3101) 'bin/hadoop job' should display the
help and silently exit
Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586337#action_12586337 ]
Amar Kamat commented on HADOOP-3101:
------------------------------------
I think we should test all the code paths that directly/indirectly depend on {{getRemainingArgs()}}.
> 'bin/hadoop job' should display the help and silently exit
> ----------------------------------------------------------
>
> Key: HADOOP-3101
> URL: https://issues.apache.org/jira/browse/HADOOP-3101
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Amar Kamat
> Assignee: Edward J. Yoon
> Priority: Minor
> Attachments: 3101.patch
>
>
> Currently 'bin/hadoop job' displays help and throws an exception. Like other commands (e.g dfs) it should silently come out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3101) 'bin/hadoop job' should display the
help and silently exit
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HADOOP-3101:
-----------------------------------
Attachment: 3101_v03.patch
Thanks for your review, owen.
I changed the JobClient help to FsShell help style.
{code}
[root@udanax hadoop]# bin/hadoop job
Usage: JobClient <command> <args>
[-submit <job-file>]
[-status <job-id>]
[-kill <job-id>]
[-events <job-id> <from-event-#> <#-of-events>]
[-history <jobOutputDir>]
[-list [all]]
[-kill-task <task-id>]
[-fail-task <task-id>]
Generic options supported are
-conf <configuration file> specify an application configuration file
-D <property=value> use value for given property
-fs <local|namenode:port> specify a namenod
-jt <local|jobtracker:port> specify a job tracker
The general command line syntax is
bin/hadoop command [genericOptions] [commandOptions]
[root@udanax hadoop]# bin/hadoop job -submit
Usage: JobClient [-submit <job-file>]
{code}
> 'bin/hadoop job' should display the help and silently exit
> ----------------------------------------------------------
>
> Key: HADOOP-3101
> URL: https://issues.apache.org/jira/browse/HADOOP-3101
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Amar Kamat
> Assignee: Edward J. Yoon
> Priority: Minor
> Attachments: 3101.patch, 3101_v02.patch, 3101_v03.patch
>
>
> Currently 'bin/hadoop job' displays help and throws an exception. Like other commands (e.g dfs) it should silently come out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3101) 'bin/hadoop job' should display the
help and silently exit
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HADOOP-3101:
-----------------------------------
Status: Patch Available (was: Open)
Submitting.
> 'bin/hadoop job' should display the help and silently exit
> ----------------------------------------------------------
>
> Key: HADOOP-3101
> URL: https://issues.apache.org/jira/browse/HADOOP-3101
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Amar Kamat
> Assignee: Edward J. Yoon
> Priority: Minor
> Attachments: 3101.patch, 3101_v02.patch
>
>
> Currently 'bin/hadoop job' displays help and throws an exception. Like other commands (e.g dfs) it should silently come out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3101) 'bin/hadoop job' should display the
help and silently exit
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590814#action_12590814 ]
Hadoop QA commented on HADOOP-3101:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12380472/3101_v03.patch
against trunk revision 645773.
@author +1. The patch does not contain any @author tags.
tests included +1. The patch appears to include 4 new or modified tests.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler warnings.
release audit +1. The applied patch does not generate any new release audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2286/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2286/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2286/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2286/console
This message is automatically generated.
> 'bin/hadoop job' should display the help and silently exit
> ----------------------------------------------------------
>
> Key: HADOOP-3101
> URL: https://issues.apache.org/jira/browse/HADOOP-3101
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Amar Kamat
> Assignee: Edward J. Yoon
> Priority: Minor
> Attachments: 3101.patch, 3101_v02.patch, 3101_v03.patch
>
>
> Currently 'bin/hadoop job' displays help and throws an exception. Like other commands (e.g dfs) it should silently come out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3101) 'bin/hadoop job' should display the
help and silently exit
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586717#action_12586717 ]
Edward J. Yoon commented on HADOOP-3101:
----------------------------------------
>> Should there be a concern?
{code}
[root@a51402 hadoop]# bin/hadoop job -jt
08/04/08 17:52:25 WARN util.GenericOptionsParser: options parsing failed: Missing argument for option:jt
usage: general options are:
-conf <configuration file> specify an application configuration file
-D <property=value> use value for given property
-fs <local|namenode:port> specify a namenode
-jt <local|jobtracker:port> specify a job tracker
Exception in thread "main" java.lang.NullPointerException
at org.apache.hadoop.util.GenericOptionsParser.getRemainingArgs(GenericOptionsParser.java:129)
at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:64)
at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:79)
at org.apache.hadoop.mapred.JobClient.main(JobClient.java:1401)
{code}
> 'bin/hadoop job' should display the help and silently exit
> ----------------------------------------------------------
>
> Key: HADOOP-3101
> URL: https://issues.apache.org/jira/browse/HADOOP-3101
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Amar Kamat
> Assignee: Edward J. Yoon
> Priority: Minor
> Attachments: 3101.patch
>
>
> Currently 'bin/hadoop job' displays help and throws an exception. Like other commands (e.g dfs) it should silently come out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3101) 'bin/hadoop job' should display the
help and silently exit
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HADOOP-3101:
-----------------------------------
Status: Open (was: Patch Available)
> 'bin/hadoop job' should display the help and silently exit
> ----------------------------------------------------------
>
> Key: HADOOP-3101
> URL: https://issues.apache.org/jira/browse/HADOOP-3101
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Amar Kamat
> Assignee: Edward J. Yoon
> Priority: Minor
> Fix For: 0.18.0
>
> Attachments: 3101.patch, 3101_v02.patch, 3101_v03.patch, 3101_v04.patch
>
>
> Currently 'bin/hadoop job' displays help and throws an exception. Like other commands (e.g dfs) it should silently come out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3101) 'bin/hadoop job' should display the
help and silently exit
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594882#action_12594882 ]
Hudson commented on HADOOP-3101:
--------------------------------
Integrated in Hadoop-trunk #483 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/483/])
> 'bin/hadoop job' should display the help and silently exit
> ----------------------------------------------------------
>
> Key: HADOOP-3101
> URL: https://issues.apache.org/jira/browse/HADOOP-3101
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Amar Kamat
> Assignee: Edward J. Yoon
> Priority: Minor
> Fix For: 0.18.0
>
> Attachments: 3101.patch, 3101_v02.patch, 3101_v03.patch, 3101_v04.patch
>
>
> Currently 'bin/hadoop job' displays help and throws an exception. Like other commands (e.g dfs) it should silently come out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3101) 'bin/hadoop job' should display the
help and silently exit
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HADOOP-3101:
-----------------------------------
Status: Patch Available (was: Open)
Resubmit
> 'bin/hadoop job' should display the help and silently exit
> ----------------------------------------------------------
>
> Key: HADOOP-3101
> URL: https://issues.apache.org/jira/browse/HADOOP-3101
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Amar Kamat
> Assignee: Edward J. Yoon
> Priority: Minor
> Fix For: 0.18.0
>
> Attachments: 3101.patch, 3101_v02.patch, 3101_v03.patch, 3101_v04.patch
>
>
> Currently 'bin/hadoop job' displays help and throws an exception. Like other commands (e.g dfs) it should silently come out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3101) 'bin/hadoop job' should display the
help and silently exit
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-3101:
----------------------------------
Status: Open (was: Patch Available)
You should remove the throw rather than comment it out as Amar already suggested.
Hiding the IOException (ie. logging at debug level) from the user is wrong. They need some indication of what went wrong.
> 'bin/hadoop job' should display the help and silently exit
> ----------------------------------------------------------
>
> Key: HADOOP-3101
> URL: https://issues.apache.org/jira/browse/HADOOP-3101
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Amar Kamat
> Assignee: Edward J. Yoon
> Priority: Minor
> Attachments: 3101.patch, 3101_v02.patch
>
>
> Currently 'bin/hadoop job' displays help and throws an exception. Like other commands (e.g dfs) it should silently come out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.