You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Swapan Shridhar <ss...@hortonworks.com> on 2016/03/25 00:24:26 UTC
Review Request 45325: Add the Config,
Start and Stop logic for: (1). Hive Server Interactive,
and (2). Associate the LLAP lifecycle to it.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45325/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Mohanty.
Bugs: AMBARI-15573
https://issues.apache.org/jira/browse/AMBARI-15573
Repository: ambari
Description
-------
Add the Config, Start and Stop logic for: (1). Hive Server Interactive (HSI), and (2). Associate the LLAP lifecycle to it.
- Start of HSI : Create LLAP package, start LLAP and then start HSI.
- Stop: Stop HSI and then LLAP.
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py f07b76f
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py PRE-CREATION
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py 8a4e7e6
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py 12cf336
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py PRE-CREATION
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 6f05fbc
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py 62fc2e3
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/startHiveserver2Interactive.sh.j2 PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/tarball_map.json 1e349a1
ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-interactive-site.xml face571
Diff: https://reviews.apache.org/r/45325/diff/
Testing
-------
Yes.
- 2.6: Installation, config, Start and Stop of Hive Server Interactive after Hive Server Batch -> Works.
- 2.6 : Instllation, config, Start and Stop of Hive Server Batch only -> Works
- 2.6 : nstallation, config, Start and Stop of Hive Server Interactive along with Hive Server Batch -> Works.
- 2.5 : Negative testing : Only Hive Batch gets installed. (Hive Server Interactive not present).
-
- Python UT : Passes.
- mvn clean test : ongoing. Will update.
Thanks,
Swapan Shridhar
Re: Review Request 45325: Add the Config,
Start and Stop logic for: (1). Hive Server Interactive,
and (2). Associate the LLAP lifecycle to it.
Posted by Swapan Shridhar <ss...@hortonworks.com>.
> On March 24, 2016, 11:41 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py, line 108
> > <https://reviews.apache.org/r/45325/diff/1/?file=1314430#file1314430line108>
> >
> > Can move fileExists inside the if.
I am not sure on this. Based on fileExists, the if is based on.
> On March 24, 2016, 11:41 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py, line 46
> > <https://reviews.apache.org/r/45325/diff/1/?file=1314432#file1314432line46>
> >
> > Is this similar to hive batch? If so, can we share some of the code?
Multiple varibales will have to passed to make it work. Can happen though. The time we merge both Hive1 and Hive2 won't hive any benefits.
> On March 24, 2016, 11:41 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py, line 496
> > <https://reviews.apache.org/r/45325/diff/1/?file=1314433#file1314433line496>
> >
> > Should not rely on this, instead, use /etc/tez_hive/$version/0 or /usr/hdp/current/$name/conf
Will open a bug to get work as suggested. As of now we dont have /usr/hdp/current/$name/conf for tez_hive2.
> On March 24, 2016, 11:41 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py, line 116
> > <https://reviews.apache.org/r/45325/diff/1/?file=1314430#file1314430line116>
> >
> > Should not do sys.exit since may not grab error message, instead, return.
Using return
- Swapan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45325/#review125366
-----------------------------------------------------------
On March 24, 2016, 11:24 p.m., Swapan Shridhar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45325/
> -----------------------------------------------------------
>
> (Updated March 24, 2016, 11:24 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15573
> https://issues.apache.org/jira/browse/AMBARI-15573
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add the Config, Start and Stop logic for: (1). Hive Server Interactive (HSI), and (2). Associate the LLAP lifecycle to it.
>
> - Start of HSI : Create LLAP package, start LLAP and then start HSI.
> - Stop: Stop HSI and then LLAP.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py f07b76f
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py 8a4e7e6
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py 12cf336
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 6f05fbc
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py 62fc2e3
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/startHiveserver2Interactive.sh.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/tarball_map.json 1e349a1
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-interactive-site.xml face571
>
> Diff: https://reviews.apache.org/r/45325/diff/
>
>
> Testing
> -------
>
> Yes.
> - 2.6: Installation, config, Start and Stop of Hive Server Interactive after Hive Server Batch -> Works.
> - 2.6 : Instllation, config, Start and Stop of Hive Server Batch only -> Works
> - 2.6 : nstallation, config, Start and Stop of Hive Server Interactive along with Hive Server Batch -> Works.
> - 2.5 : Negative testing : Only Hive Batch gets installed. (Hive Server Interactive not present).
> -
> - Python UT : Passes.
> - mvn clean test : ongoing. Will update.
>
>
> Thanks,
>
> Swapan Shridhar
>
>
Re: Review Request 45325: Add the Config,
Start and Stop logic for: (1). Hive Server Interactive,
and (2). Associate the LLAP lifecycle to it.
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45325/#review125366
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py (line 53)
<https://reviews.apache.org/r/45325/#comment188128>
Add some pydoc for what this function does.
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py (line 44)
<https://reviews.apache.org/r/45325/#comment188129>
No need to add "as"
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py (line 93)
<https://reviews.apache.org/r/45325/#comment188130>
use python function names, start_llap, stop_llap
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py (line 94)
<https://reviews.apache.org/r/45325/#comment188135>
initialize splits to [] since the rest of the code assumes it is a string array
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py (line 108)
<https://reviews.apache.org/r/45325/#comment188131>
Can move fileExists inside the if.
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py (line 116)
<https://reviews.apache.org/r/45325/#comment188132>
Should not do sys.exit since may not grab error message, instead, return.
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py (line 126)
<https://reviews.apache.org/r/45325/#comment188134>
Just catch a general exception since OSError and IOError seem to be doing the same thing
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py (line 139)
<https://reviews.apache.org/r/45325/#comment188136>
pythonic variable names, llap_folder, dir_exists
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py (line 149)
<https://reviews.apache.org/r/45325/#comment188137>
Remove unnecessary spaces
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py (line 167)
<https://reviews.apache.org/r/45325/#comment188138>
Same comments regarding sys.exit
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py (line 46)
<https://reviews.apache.org/r/45325/#comment188139>
Is this similar to hive batch? If so, can we share some of the code?
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py (line 486)
<https://reviews.apache.org/r/45325/#comment188140>
Use os.path.join
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py (line 491)
<https://reviews.apache.org/r/45325/#comment188141>
Should not rely on this, instead, use /etc/tez_hive/$version/0 or /usr/hdp/current/$name/conf
- Alejandro Fernandez
On March 24, 2016, 11:24 p.m., Swapan Shridhar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45325/
> -----------------------------------------------------------
>
> (Updated March 24, 2016, 11:24 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15573
> https://issues.apache.org/jira/browse/AMBARI-15573
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add the Config, Start and Stop logic for: (1). Hive Server Interactive (HSI), and (2). Associate the LLAP lifecycle to it.
>
> - Start of HSI : Create LLAP package, start LLAP and then start HSI.
> - Stop: Stop HSI and then LLAP.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py f07b76f
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py 8a4e7e6
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py 12cf336
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 6f05fbc
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py 62fc2e3
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/startHiveserver2Interactive.sh.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/tarball_map.json 1e349a1
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-interactive-site.xml face571
>
> Diff: https://reviews.apache.org/r/45325/diff/
>
>
> Testing
> -------
>
> Yes.
> - 2.6: Installation, config, Start and Stop of Hive Server Interactive after Hive Server Batch -> Works.
> - 2.6 : Instllation, config, Start and Stop of Hive Server Batch only -> Works
> - 2.6 : nstallation, config, Start and Stop of Hive Server Interactive along with Hive Server Batch -> Works.
> - 2.5 : Negative testing : Only Hive Batch gets installed. (Hive Server Interactive not present).
> -
> - Python UT : Passes.
> - mvn clean test : ongoing. Will update.
>
>
> Thanks,
>
> Swapan Shridhar
>
>
Re: Review Request 45325: Add the Config,
Start and Stop logic for: (1). Hive Server Interactive,
and (2). Associate the LLAP lifecycle to it.
Posted by Swapan Shridhar <ss...@hortonworks.com>.
> On March 25, 2016, 4:22 a.m., Sumit Mohanty wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py, line 50
> > <https://reviews.apache.org/r/45325/diff/1/?file=1314428#file1314428line50>
> >
> > Are these paths verified with the Hive team?
Yes. Different folder. Same tar file name.
> On March 25, 2016, 4:22 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py, line 57
> > <https://reviews.apache.org/r/45325/diff/1/?file=1314429#file1314429line57>
> >
> > Is it copied for each start() command?
Yes. Happens same for Hive Batch also. I see a point in this if custom tar file is kept. It will be picked and copied. Your inputs ? I can fix it for both if required.
> On March 25, 2016, 4:22 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py, line 94
> > <https://reviews.apache.org/r/45325/diff/1/?file=1314429#file1314429line94>
> >
> > Nit: the formatting is off. Extra space for all lines after first one.
Fixed.
> On March 25, 2016, 4:22 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py, line 108
> > <https://reviews.apache.org/r/45325/diff/1/?file=1314429#file1314429line108>
> >
> > We should rename this variable - and also the variable above it "target". Rename them to be something more descriptive.
Named target_hive_interactive
> On March 25, 2016, 4:22 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py, line 120
> > <https://reviews.apache.org/r/45325/diff/1/?file=1314429#file1314429line120>
> >
> > Can we rename this also to create_directory()?
Fixed.
> On March 25, 2016, 4:22 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py, line 97
> > <https://reviews.apache.org/r/45325/diff/1/?file=1314430#file1314430line97>
> >
> > Use Execute() and pass in params as needed.
Fixed.
> On March 25, 2016, 4:22 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py, line 112
> > <https://reviews.apache.org/r/45325/diff/1/?file=1314430#file1314430line112>
> >
> > Lets remove the sleep - why does hive interactive need to have LLAP running? Even if we need a sleep it should be 10-30 seconds only
LLAP needs to be up and running (we may find LLAP in accepted state) if we don't wait based on the cluster load. Ultimately, we will check LLAP slider status status. There is a TODO/comment for that.
> On March 25, 2016, 4:22 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py, line 115
> > <https://reviews.apache.org/r/45325/diff/1/?file=1314430#file1314430line115>
> >
> > We should log the package name as well.
Fixed.
> On March 25, 2016, 4:22 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py, line 118
> > <https://reviews.apache.org/r/45325/diff/1/?file=1314430#file1314430line118>
> >
> > If we check for the file, should we check for the message? is there a way to control the output location of the file or give the file a name. It seems that this process is error prone. I would rather have full control on the file name or path and then check the existence of the file rather than message.
we can put a requirement on Slider/LLAP. Can't figure out a way as of now. Looks trivial if they can accept the supplied folder name
> On March 25, 2016, 4:22 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py, line 155
> > <https://reviews.apache.org/r/45325/diff/1/?file=1314430#file1314430line155>
> >
> > Use Execute()
Done.
> On March 25, 2016, 4:22 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py, line 160
> > <https://reviews.apache.org/r/45325/diff/1/?file=1314430#file1314430line160>
> >
> > Use Execute()
Done.
> On March 25, 2016, 4:22 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py, line 80
> > <https://reviews.apache.org/r/45325/diff/1/?file=1314430#file1314430line80>
> >
> > What's FOR SECURITY?
Nothing. Wrong comment. Removed.
> On March 25, 2016, 4:22 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py, line 76
> > <https://reviews.apache.org/r/45325/diff/1/?file=1314429#file1314429line76>
> >
> > Can you add a comment as to what does this do?
Done.
- Swapan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45325/#review125386
-----------------------------------------------------------
On March 24, 2016, 11:24 p.m., Swapan Shridhar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45325/
> -----------------------------------------------------------
>
> (Updated March 24, 2016, 11:24 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15573
> https://issues.apache.org/jira/browse/AMBARI-15573
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add the Config, Start and Stop logic for: (1). Hive Server Interactive (HSI), and (2). Associate the LLAP lifecycle to it.
>
> - Start of HSI : Create LLAP package, start LLAP and then start HSI.
> - Stop: Stop HSI and then LLAP.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py f07b76f
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py 8a4e7e6
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py 12cf336
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 6f05fbc
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py 62fc2e3
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/startHiveserver2Interactive.sh.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/tarball_map.json 1e349a1
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-interactive-site.xml face571
>
> Diff: https://reviews.apache.org/r/45325/diff/
>
>
> Testing
> -------
>
> Yes.
> - 2.6: Installation, config, Start and Stop of Hive Server Interactive after Hive Server Batch -> Works.
> - 2.6 : Instllation, config, Start and Stop of Hive Server Batch only -> Works
> - 2.6 : nstallation, config, Start and Stop of Hive Server Interactive along with Hive Server Batch -> Works.
> - 2.5 : Negative testing : Only Hive Batch gets installed. (Hive Server Interactive not present).
> -
> - Python UT : Passes.
> - mvn clean test : ongoing. Will update.
>
>
> Thanks,
>
> Swapan Shridhar
>
>
Re: Review Request 45325: Add the Config,
Start and Stop logic for: (1). Hive Server Interactive,
and (2). Associate the LLAP lifecycle to it.
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45325/#review125386
-----------------------------------------------------------
ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py (line 50)
<https://reviews.apache.org/r/45325/#comment188165>
Are these paths verified with the Hive team?
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py (line 57)
<https://reviews.apache.org/r/45325/#comment188166>
Is it copied for each start() command?
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py (line 76)
<https://reviews.apache.org/r/45325/#comment188167>
Can you add a comment as to what does this do?
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py (line 94)
<https://reviews.apache.org/r/45325/#comment188168>
Nit: the formatting is off. Extra space for all lines after first one.
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py (line 108)
<https://reviews.apache.org/r/45325/#comment188169>
We should rename this variable - and also the variable above it "target". Rename them to be something more descriptive.
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py (line 120)
<https://reviews.apache.org/r/45325/#comment188170>
Can we rename this also to create_directory()?
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py (line 80)
<https://reviews.apache.org/r/45325/#comment188171>
What's FOR SECURITY?
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py (line 97)
<https://reviews.apache.org/r/45325/#comment188172>
Use Execute() and pass in params as needed.
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py (line 112)
<https://reviews.apache.org/r/45325/#comment188174>
Lets remove the sleep - why does hive interactive need to have LLAP running? Even if we need a sleep it should be 10-30 seconds only
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py (line 115)
<https://reviews.apache.org/r/45325/#comment188173>
We should log the package name as well.
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py (line 118)
<https://reviews.apache.org/r/45325/#comment188175>
If we check for the file, should we check for the message? is there a way to control the output location of the file or give the file a name. It seems that this process is error prone. I would rather have full control on the file name or path and then check the existence of the file rather than message.
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py (line 135)
<https://reviews.apache.org/r/45325/#comment188176>
Anyway, we are deleting the file - so its good.
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py (line 155)
<https://reviews.apache.org/r/45325/#comment188177>
Use Execute()
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py (line 160)
<https://reviews.apache.org/r/45325/#comment188178>
Use Execute()
- Sumit Mohanty
On March 24, 2016, 11:24 p.m., Swapan Shridhar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45325/
> -----------------------------------------------------------
>
> (Updated March 24, 2016, 11:24 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15573
> https://issues.apache.org/jira/browse/AMBARI-15573
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add the Config, Start and Stop logic for: (1). Hive Server Interactive (HSI), and (2). Associate the LLAP lifecycle to it.
>
> - Start of HSI : Create LLAP package, start LLAP and then start HSI.
> - Stop: Stop HSI and then LLAP.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py f07b76f
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py 8a4e7e6
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py 12cf336
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 6f05fbc
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py 62fc2e3
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/startHiveserver2Interactive.sh.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/tarball_map.json 1e349a1
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-interactive-site.xml face571
>
> Diff: https://reviews.apache.org/r/45325/diff/
>
>
> Testing
> -------
>
> Yes.
> - 2.6: Installation, config, Start and Stop of Hive Server Interactive after Hive Server Batch -> Works.
> - 2.6 : Instllation, config, Start and Stop of Hive Server Batch only -> Works
> - 2.6 : nstallation, config, Start and Stop of Hive Server Interactive along with Hive Server Batch -> Works.
> - 2.5 : Negative testing : Only Hive Batch gets installed. (Hive Server Interactive not present).
> -
> - Python UT : Passes.
> - mvn clean test : ongoing. Will update.
>
>
> Thanks,
>
> Swapan Shridhar
>
>
Re: Review Request 45325: Add the Config,
Start and Stop logic for: (1). Hive Server Interactive,
and (2). Associate the LLAP lifecycle to it.
Posted by Swapan Shridhar <ss...@hortonworks.com>.
> On March 27, 2016, 12:05 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py, line 120
> > <https://reviews.apache.org/r/45325/diff/2/?file=1315407#file1315407line120>
> >
> > Lets open a follow up JIRA to avoid sleeping and tracking completion of the command.
https://hortonworks.jira.com/browse/BUG-55074
> On March 27, 2016, 12:05 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py, line 156
> > <https://reviews.apache.org/r/45325/diff/2/?file=1315407#file1315407line156>
> >
> > Why don't we move this function to hive service interactive? That seems to be the file for helper methods.
Moved stop_llap and start_llap.
> On March 27, 2016, 12:05 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py, line 160
> > <https://reviews.apache.org/r/45325/diff/2/?file=1315407#file1315407line160>
> >
> > We should uses Execute() here - e.g.
> > Execute(stop_cmd, user=params.hive_user, timeout=30). It has several other construct to control runaway command, whether to wait for finish or not etc. Instead we can develop a check command to see if slider app is alive and use that to decide to call destroy or not. The status command can be used in the status() call as well.
Done. Using Ececute().
status() fn. created within Hive will be based out of when 'slider status llap?' is enhanced. Put a TODO.
- Swapan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45325/#review125555
-----------------------------------------------------------
On March 26, 2016, 4:27 a.m., Swapan Shridhar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45325/
> -----------------------------------------------------------
>
> (Updated March 26, 2016, 4:27 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15573
> https://issues.apache.org/jira/browse/AMBARI-15573
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add the Config, Start and Stop logic for: (1). Hive Server Interactive (HSI), and (2). Associate the LLAP lifecycle to it.
>
> - Start of HSI : Create LLAP package, start LLAP and then start HSI.
> - Stop: Stop HSI and then LLAP.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py f07b76f
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 3532efc
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py 8a4e7e6
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py 12cf336
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 6f05fbc
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py a6e4a47
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/startHiveserver2Interactive.sh.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/tarball_map.json 1e349a1
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml face571
>
> Diff: https://reviews.apache.org/r/45325/diff/
>
>
> Testing
> -------
>
> Yes.
> - 2.6: Installation, config, Start and Stop of Hive Server Interactive after Hive Server Batch -> Works.
> - 2.6 : Instllation, config, Start and Stop of Hive Server Batch only -> Works
> - 2.6 : nstallation, config, Start and Stop of Hive Server Interactive along with Hive Server Batch -> Works.
> - 2.5 : Negative testing : Only Hive Batch gets installed. (Hive Server Interactive not present).
> -
> - Python UT : Passes.
> - mvn clean test : ongoing. Will update.
>
>
> Thanks,
>
> Swapan Shridhar
>
>
Re: Review Request 45325: Add the Config,
Start and Stop logic for: (1). Hive Server Interactive,
and (2). Associate the LLAP lifecycle to it.
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45325/#review125555
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py (line 120)
<https://reviews.apache.org/r/45325/#comment188407>
Lets open a follow up JIRA to avoid sleeping and tracking completion of the command.
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py (line 156)
<https://reviews.apache.org/r/45325/#comment188409>
Why don't we move this function to hive service interactive? That seems to be the file for helper methods.
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py (line 160)
<https://reviews.apache.org/r/45325/#comment188408>
We should uses Execute() here - e.g.
Execute(stop_cmd, user=params.hive_user, timeout=30). It has several other construct to control runaway command, whether to wait for finish or not etc. Instead we can develop a check command to see if slider app is alive and use that to decide to call destroy or not. The status command can be used in the status() call as well.
- Sumit Mohanty
On March 26, 2016, 4:27 a.m., Swapan Shridhar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45325/
> -----------------------------------------------------------
>
> (Updated March 26, 2016, 4:27 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15573
> https://issues.apache.org/jira/browse/AMBARI-15573
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add the Config, Start and Stop logic for: (1). Hive Server Interactive (HSI), and (2). Associate the LLAP lifecycle to it.
>
> - Start of HSI : Create LLAP package, start LLAP and then start HSI.
> - Stop: Stop HSI and then LLAP.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py f07b76f
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 3532efc
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py 8a4e7e6
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py 12cf336
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 6f05fbc
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py a6e4a47
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/startHiveserver2Interactive.sh.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/tarball_map.json 1e349a1
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml face571
>
> Diff: https://reviews.apache.org/r/45325/diff/
>
>
> Testing
> -------
>
> Yes.
> - 2.6: Installation, config, Start and Stop of Hive Server Interactive after Hive Server Batch -> Works.
> - 2.6 : Instllation, config, Start and Stop of Hive Server Batch only -> Works
> - 2.6 : nstallation, config, Start and Stop of Hive Server Interactive along with Hive Server Batch -> Works.
> - 2.5 : Negative testing : Only Hive Batch gets installed. (Hive Server Interactive not present).
> -
> - Python UT : Passes.
> - mvn clean test : ongoing. Will update.
>
>
> Thanks,
>
> Swapan Shridhar
>
>
Re: Review Request 45325: Add the Config,
Start and Stop logic for: (1). Hive Server Interactive,
and (2). Associate the LLAP lifecycle to it.
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45325/#review125686
-----------------------------------------------------------
Ship it!
Ship It!
- Sumit Mohanty
On March 27, 2016, 11:14 p.m., Swapan Shridhar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45325/
> -----------------------------------------------------------
>
> (Updated March 27, 2016, 11:14 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15573
> https://issues.apache.org/jira/browse/AMBARI-15573
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add the Config, Start and Stop logic for: (1). Hive Server Interactive (HSI), and (2). Associate the LLAP lifecycle to it.
>
> - Start of HSI : Create LLAP package, start LLAP and then start HSI.
> - Stop: Stop HSI and then LLAP.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py f07b76f
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 3532efc
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py 8a4e7e6
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py 12cf336
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 6f05fbc
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py a6e4a47
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/startHiveserver2Interactive.sh.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/tarball_map.json 1e349a1
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml face571
>
> Diff: https://reviews.apache.org/r/45325/diff/
>
>
> Testing
> -------
>
> Yes.
> - 2.6: Installation, config, Start and Stop of Hive Server Interactive after Hive Server Batch -> Works.
> - 2.6 : Instllation, config, Start and Stop of Hive Server Batch only -> Works
> - 2.6 : nstallation, config, Start and Stop of Hive Server Interactive along with Hive Server Batch -> Works.
> - 2.5 : Negative testing : Only Hive Batch gets installed. (Hive Server Interactive not present).
> -
> - Python UT : Passes.
> - mvn clean test : ongoing. Will update.
>
>
> Thanks,
>
> Swapan Shridhar
>
>
Re: Review Request 45325: Add the Config,
Start and Stop logic for: (1). Hive Server Interactive,
and (2). Associate the LLAP lifecycle to it.
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45325/#review125762
-----------------------------------------------------------
Fix it, then Ship it!
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py (line 107)
<https://reviews.apache.org/r/45325/#comment188612>
Why does this need to accept self?
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py (line 147)
<https://reviews.apache.org/r/45325/#comment188613>
Stylistically, better to always end with a "return False", and only return True in the success condition.
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py (line 155)
<https://reviews.apache.org/r/45325/#comment188614>
May want to enclose the content of finally inside its own try-except
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py (line 163)
<https://reviews.apache.org/r/45325/#comment188615>
Use LOG.
- Alejandro Fernandez
On March 27, 2016, 11:14 p.m., Swapan Shridhar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45325/
> -----------------------------------------------------------
>
> (Updated March 27, 2016, 11:14 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15573
> https://issues.apache.org/jira/browse/AMBARI-15573
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add the Config, Start and Stop logic for: (1). Hive Server Interactive (HSI), and (2). Associate the LLAP lifecycle to it.
>
> - Start of HSI : Create LLAP package, start LLAP and then start HSI.
> - Stop: Stop HSI and then LLAP.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py f07b76f
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 3532efc
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py 8a4e7e6
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py 12cf336
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 6f05fbc
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py a6e4a47
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/startHiveserver2Interactive.sh.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/tarball_map.json 1e349a1
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml face571
>
> Diff: https://reviews.apache.org/r/45325/diff/
>
>
> Testing
> -------
>
> Yes.
> - 2.6: Installation, config, Start and Stop of Hive Server Interactive after Hive Server Batch -> Works.
> - 2.6 : Instllation, config, Start and Stop of Hive Server Batch only -> Works
> - 2.6 : nstallation, config, Start and Stop of Hive Server Interactive along with Hive Server Batch -> Works.
> - 2.5 : Negative testing : Only Hive Batch gets installed. (Hive Server Interactive not present).
> -
> - Python UT : Passes.
> - mvn clean test : ongoing. Will update.
>
>
> Thanks,
>
> Swapan Shridhar
>
>
Re: Review Request 45325: Add the Config,
Start and Stop logic for: (1). Hive Server Interactive,
and (2). Associate the LLAP lifecycle to it.
Posted by Swapan Shridhar <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45325/
-----------------------------------------------------------
(Updated March 27, 2016, 11:14 p.m.)
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Mohanty.
Changes
-------
Addressed review comments.
Tested.
Bugs: AMBARI-15573
https://issues.apache.org/jira/browse/AMBARI-15573
Repository: ambari
Description
-------
Add the Config, Start and Stop logic for: (1). Hive Server Interactive (HSI), and (2). Associate the LLAP lifecycle to it.
- Start of HSI : Create LLAP package, start LLAP and then start HSI.
- Stop: Stop HSI and then LLAP.
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py f07b76f
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 3532efc
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py PRE-CREATION
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py 8a4e7e6
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py 12cf336
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py PRE-CREATION
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 6f05fbc
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py a6e4a47
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/startHiveserver2Interactive.sh.j2 PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/tarball_map.json 1e349a1
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml face571
Diff: https://reviews.apache.org/r/45325/diff/
Testing
-------
Yes.
- 2.6: Installation, config, Start and Stop of Hive Server Interactive after Hive Server Batch -> Works.
- 2.6 : Instllation, config, Start and Stop of Hive Server Batch only -> Works
- 2.6 : nstallation, config, Start and Stop of Hive Server Interactive along with Hive Server Batch -> Works.
- 2.5 : Negative testing : Only Hive Batch gets installed. (Hive Server Interactive not present).
-
- Python UT : Passes.
- mvn clean test : ongoing. Will update.
Thanks,
Swapan Shridhar
Re: Review Request 45325: Add the Config,
Start and Stop logic for: (1). Hive Server Interactive,
and (2). Associate the LLAP lifecycle to it.
Posted by Swapan Shridhar <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45325/
-----------------------------------------------------------
(Updated March 26, 2016, 4:27 a.m.)
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Mohanty.
Changes
-------
- Incorporated review suggestions.
- Synced to TOT.
Bugs: AMBARI-15573
https://issues.apache.org/jira/browse/AMBARI-15573
Repository: ambari
Description
-------
Add the Config, Start and Stop logic for: (1). Hive Server Interactive (HSI), and (2). Associate the LLAP lifecycle to it.
- Start of HSI : Create LLAP package, start LLAP and then start HSI.
- Stop: Stop HSI and then LLAP.
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py f07b76f
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 3532efc
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py PRE-CREATION
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py 8a4e7e6
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py 12cf336
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py PRE-CREATION
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 6f05fbc
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py a6e4a47
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/startHiveserver2Interactive.sh.j2 PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/tarball_map.json 1e349a1
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml face571
Diff: https://reviews.apache.org/r/45325/diff/
Testing
-------
Yes.
- 2.6: Installation, config, Start and Stop of Hive Server Interactive after Hive Server Batch -> Works.
- 2.6 : Instllation, config, Start and Stop of Hive Server Batch only -> Works
- 2.6 : nstallation, config, Start and Stop of Hive Server Interactive along with Hive Server Batch -> Works.
- 2.5 : Negative testing : Only Hive Batch gets installed. (Hive Server Interactive not present).
-
- Python UT : Passes.
- mvn clean test : ongoing. Will update.
Thanks,
Swapan Shridhar